Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Formats the MageForge Magento 2 module codebase using mago format and introduces a mago.toml configuration intended to align formatting with PHPCS, making automated checks and reviews more consistent.
Changes:
- Apply automated formatting across PHP/PHTML files (trailing commas, argument wrapping, chaining layout, whitespace cleanup).
- Normalize a number of method signatures/calls and array formatting to a consistent style.
- Add
mago.tomlconfiguration for formatter behavior.
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/view/frontend/templates/inspector.phtml | Whitespace cleanup in template. |
| src/registration.php | Collapse module registration call to a single line. |
| src/Service/ThemeSuggester.php | Constructor formatting (trailing comma). |
| src/Service/ThemeCleaner.php | Signature/callsite formatting; inline sprintf calls. |
| src/Service/ThemeBuilder/TailwindCSS/Builder.php | Signature/callsite formatting; inline method calls. |
| src/Service/ThemeBuilder/MagentoStandard/Builder.php | Formatting for detect() and method signatures/calls. |
| src/Service/ThemeBuilder/HyvaThemes/Builder.php | Formatting plus PHPCS suppression comment adjustments. |
| src/Service/ThemeBuilder/BuilderPool.php | Constructor formatting (default arg + trailing comma). |
| src/Service/ThemeBuilder/BuilderInterface.php | Interface signature formatting (trailing commas / one-line method). |
| src/Service/SymlinkCleaner.php | Signature formatting; inline sprintf calls. |
| src/Service/StaticContentDeployer.php | Signature formatting; array argument formatting. |
| src/Service/StaticContentCleaner.php | Signature formatting; minor expression simplification. |
| src/Service/StandardThemeBuilder.php | Import ordering + constructor/build signature formatting. |
| src/Service/NodeSetupValidator.php | Formatting changes (imports/constructor/signatures). |
| src/Service/NodePackageManager.php | Constructor formatting (trailing comma). |
| src/Service/Inspector/Cache/BlockCacheCollector.php | Minor cast spacing formatting. |
| src/Service/Hyva/ModuleScanner.php | Constructor formatting (trailing comma). |
| src/Service/Hyva/IncompatibilityDetector.php | Constructor formatting (trailing comma). |
| src/Service/Hyva/CompatibilityChecker.php | Signature/call formatting; inline sprintf usage. |
| src/Service/GruntTaskRunner.php | Signature formatting; brace placement. |
| src/Service/DependencyChecker.php | String quote normalization + minor formatting. |
| src/Service/CacheCleaner.php | Inline shell execute call formatting. |
| src/Model/ThemePath.php | Constructor formatting (trailing comma). |
| src/Model/ThemeList.php | Constructor formatting (trailing comma). |
| src/Model/TemplateEngine/Plugin/InspectorHints.php | Constructor/method signature formatting (trailing comma). |
| src/Model/TemplateEngine/Decorator/InspectorHints.php | Signature formatting and trailing commas in calls. |
| src/Console/Command/Theme/WatchCommand.php | Fluent configure formatting; inline helper call. |
| src/Console/Command/Theme/TokensCommand.php | Fluent configure formatting; inline helper call. |
| src/Console/Command/Theme/ListCommand.php | Fluent configure formatting; trailing comma in table row. |
| src/Console/Command/Theme/CleanCommand.php | Fluent configure formatting; string quote normalization; trailing commas. |
| src/Console/Command/Theme/BuildCommand.php | Fluent configure formatting; string quote normalization; inline helper calls. |
| src/Console/Command/System/VersionCommand.php | Fluent configure formatting; array trailing commas; inline fileGetContents. |
| src/Console/Command/System/CheckCommand.php | Table formatting; list formatting; minor expression formatting. |
| src/Console/Command/Hyva/CompatibilityCheckCommand.php | Fluent configure formatting; inline prompt creation; ternary simplification. |
| src/Console/Command/Dev/InspectorCommand.php | Fluent configure formatting and heredoc help formatting. |
| src/Console/Command/AbstractCommand.php | Signature formatting + ternary parentheses removal. |
| src/Block/Inspector.php | Constructor formatting (default arg + trailing comma). |
| mago.toml | Add formatter configuration for PHP/PHTML sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nur
mago formatlaufen lassen mitmago.tomldie der phpcs entspricht.Tool kommt nachträglich ins Repo, damit Error Checks direkt laufen können und Review leichter ist.