Merged
Conversation
- Add `OnUpdateCheckIntervalChanged` action and update `ProfileState` to include `updateCheckIntervalHours`. - Implement `getUpdateCheckInterval` and `setUpdateCheckInterval` in `ThemesRepository`. - Add `UpdateScheduleManager` interface with platform-specific implementations to handle rescheduling of background tasks. - Implement `reschedule` logic in `UpdateScheduler` (Android) using WorkManager with `ExistingPeriodicWorkPolicy.UPDATE`. - Add a new "Updates" section to the Profile screen with a selection card for intervals (3h, 6h, 12h, 24h). - Register `UpdateScheduleManager` in Android and JVM dependency injection modules.
Contributor
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a cross-platform UpdateScheduleManager, storage and UI for update-check interval, WorkManager reschedule API, platform DI bindings, Android app self-registration as an InstalledApp, and background rescheduling at startup and on interval changes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant VM
participant Repo as ThemesRepository
participant Manager as UpdateScheduleManager
participant Scheduler as UpdateScheduler
participant WM as WorkManager
User->>UI: Select interval (e.g. 6h)
UI->>VM: OnUpdateCheckIntervalChanged(6)
VM->>Repo: setUpdateCheckInterval(6)
Repo-->>VM: persisted
VM->>Manager: reschedule(6)
Manager->>Scheduler: reschedule(context, 6)
Scheduler->>WM: enqueue PeriodicWorkRequest(interval=6h, UPDATE)
WM-->>Scheduler: scheduled
Scheduler-->>Manager: done
Manager-->>VM: done
VM-->>UI: state.updateCheckIntervalHours = 6
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
core/data/src/commonMain/kotlin/zed/rainxch/core/data/repository/ThemesRepositoryImpl.kt (1)
118-122: Consider validating thehoursparameter.The setter accepts any
Longvalue, including zero or negative values, which would result in invalid scheduling behavior. Consider adding validation to ensure the interval is within acceptable bounds.💡 Optional fix to add validation
override suspend fun setUpdateCheckInterval(hours: Long) { + require(hours > 0) { "Update check interval must be positive" } preferences.edit { prefs -> prefs[UPDATE_CHECK_INTERVAL_KEY] = hours } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/data/src/commonMain/kotlin/zed/rainxch/core/data/repository/ThemesRepositoryImpl.kt` around lines 118 - 122, The setter setUpdateCheckInterval currently writes any Long into UPDATE_CHECK_INTERVAL_KEY via preferences.edit without validation; update it to validate the hours parameter (e.g., require hours > 0 and optionally enforce an upper bound) before writing to preferences—either throw an IllegalArgumentException for invalid values or clamp to a safe range—and document the behavior so callers of setUpdateCheckInterval know invalid inputs are rejected or normalized.feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/components/sections/Installation.kt (2)
431-434: Avoid re-dispatch on already-selected interval.Guard the chip click to no-op when the current option is already selected, so you avoid redundant repository writes and scheduler calls.
Small click-guard improvement
FilterChip( selected = isSelected, - onClick = { onIntervalSelected(hours) }, + onClick = { + if (!isSelected) onIntervalSelected(hours) + }, label = {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/components/sections/Installation.kt` around lines 431 - 434, The FilterChip onClick currently always calls onIntervalSelected(hours) even when the option is already selected; change the onClick handler inside the FilterChip component to first check isSelected and return/do nothing if true, otherwise call onIntervalSelected(hours) so you avoid redundant repository writes and scheduler updates (refer to the FilterChip onClick lambda, the isSelected boolean and the onIntervalSelected(hours) callback).
105-110: Move Android-only updates UI out ofcommonMain.This section is explicitly Android-only but implemented in shared source with a runtime platform check. Prefer source-set split (
androidMain/jvmMain) using expect/actual or platform-specific composition entry points.As per coding guidelines
**/commonMain/**/*.kt: Shared code must be incommonMainsource set and use expect/actual for platform-specific APIs; and**/{androidMain,jvmMain}/**/*.kt: Platform-specific implementations must be inandroidMainandjvmMain.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/components/sections/Installation.kt` around lines 105 - 110, The function LazyListScope.updatesSection in common code contains Android-only UI guarded by getPlatform() == Platform.ANDROID; move this Android-specific implementation out of commonMain into androidMain (e.g., create an actual implementation of an expect function or a platform-specific composition entry point) and replace the commonMain stub with a platform-agnostic expect declaration (or no-op) that accepts the same signature (state: ProfileState, onAction: (ProfileAction) -> Unit). Remove the runtime getPlatform() check from commonMain, implement the Android UI in androidMain using the same function name (LazyListScope.updatesSection) or an actual implementation, and keep ProfileState and ProfileAction usage consistent across expect/actual boundaries.core/data/src/androidMain/kotlin/zed/rainxch/core/data/services/UpdateScheduler.kt (1)
80-95: Extract shared periodic work request creation.
reschedule()duplicates the same periodic-request setup used inschedule(). A shared helper will prevent config drift (constraints/backoff) across the two paths.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/data/src/androidMain/kotlin/zed/rainxch/core/data/services/UpdateScheduler.kt` around lines 80 - 95, The reschedule() and schedule() paths duplicate PeriodicWorkRequest construction (constraints, backoff, repeatInterval) for UpdateCheckWorker; extract that logic into a single helper function (e.g., buildUpdateCheckRequest or createPeriodicRequest) and have both schedule() and reschedule() call it so constraints and backoff criteria are defined in one place; ensure the helper returns a PeriodicWorkRequest (built with PeriodicWorkRequestBuilder<UpdateCheckWorker> and using the same intervalHours and TimeUnit) and replace the inline builders in schedule() and reschedule() with a call to this helper.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt`:
- Around line 98-109: Replace hardcoded SELF_PACKAGE_NAME usage with the runtime
package name from the Application context (this.packageName) when checking
repo.getAppByPackage and when constructing InstalledApp, and add an early return
if packageMonitor.getInstalledPackageInfo(...) returns null so you don't persist
an InstalledApp with empty versionName/versionCode; specifically update the
logic around getInstalledPackageInfo, repo.getAppByPackage, InstalledApp
creation and persistence (and apply the same change to the other occurrence
around lines 148-150) to use runtime packageName and bail out when systemInfo is
null.
In
`@feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileViewModel.kt`:
- Around line 235-243: Normalize and validate the incoming update-interval value
to the supported set {3,6,12,24} before you persist it, update _state, or pass
it to any scheduler: in loadUpdateCheckInterval() wrap the collected hours from
themesRepository.getUpdateCheckInterval().collect with a normalization function
(e.g., normalizeUpdateInterval(hours)) and use the normalized value when calling
_state.update and when any scheduling functions are invoked; do the same in the
code path that writes/updates the repository (the method that saves the
interval) and in the scheduler invocation (e.g., scheduleUpdateCheck or similar)
so all writes and scheduling always use the normalized value.
---
Nitpick comments:
In
`@core/data/src/androidMain/kotlin/zed/rainxch/core/data/services/UpdateScheduler.kt`:
- Around line 80-95: The reschedule() and schedule() paths duplicate
PeriodicWorkRequest construction (constraints, backoff, repeatInterval) for
UpdateCheckWorker; extract that logic into a single helper function (e.g.,
buildUpdateCheckRequest or createPeriodicRequest) and have both schedule() and
reschedule() call it so constraints and backoff criteria are defined in one
place; ensure the helper returns a PeriodicWorkRequest (built with
PeriodicWorkRequestBuilder<UpdateCheckWorker> and using the same intervalHours
and TimeUnit) and replace the inline builders in schedule() and reschedule()
with a call to this helper.
In
`@core/data/src/commonMain/kotlin/zed/rainxch/core/data/repository/ThemesRepositoryImpl.kt`:
- Around line 118-122: The setter setUpdateCheckInterval currently writes any
Long into UPDATE_CHECK_INTERVAL_KEY via preferences.edit without validation;
update it to validate the hours parameter (e.g., require hours > 0 and
optionally enforce an upper bound) before writing to preferences—either throw an
IllegalArgumentException for invalid values or clamp to a safe range—and
document the behavior so callers of setUpdateCheckInterval know invalid inputs
are rejected or normalized.
In
`@feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/components/sections/Installation.kt`:
- Around line 431-434: The FilterChip onClick currently always calls
onIntervalSelected(hours) even when the option is already selected; change the
onClick handler inside the FilterChip component to first check isSelected and
return/do nothing if true, otherwise call onIntervalSelected(hours) so you avoid
redundant repository writes and scheduler updates (refer to the FilterChip
onClick lambda, the isSelected boolean and the onIntervalSelected(hours)
callback).
- Around line 105-110: The function LazyListScope.updatesSection in common code
contains Android-only UI guarded by getPlatform() == Platform.ANDROID; move this
Android-specific implementation out of commonMain into androidMain (e.g., create
an actual implementation of an expect function or a platform-specific
composition entry point) and replace the commonMain stub with a
platform-agnostic expect declaration (or no-op) that accepts the same signature
(state: ProfileState, onAction: (ProfileAction) -> Unit). Remove the runtime
getPlatform() check from commonMain, implement the Android UI in androidMain
using the same function name (LazyListScope.updatesSection) or an actual
implementation, and keep ProfileState and ProfileAction usage consistent across
expect/actual boundaries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c30b7cc9-8cc2-4e31-9d53-c3fcfd5db6e7
📒 Files selected for processing (15)
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.ktcore/data/src/androidMain/kotlin/zed/rainxch/core/data/di/PlatformModule.android.ktcore/data/src/androidMain/kotlin/zed/rainxch/core/data/services/AndroidUpdateScheduleManager.ktcore/data/src/androidMain/kotlin/zed/rainxch/core/data/services/UpdateScheduler.ktcore/data/src/commonMain/kotlin/zed/rainxch/core/data/repository/ThemesRepositoryImpl.ktcore/data/src/jvmMain/kotlin/zed/rainxch/core/data/di/PlatformModule.jvm.ktcore/data/src/jvmMain/kotlin/zed/rainxch/core/data/services/DesktopUpdateScheduleManager.ktcore/domain/src/commonMain/kotlin/zed/rainxch/core/domain/repository/ThemesRepository.ktcore/domain/src/commonMain/kotlin/zed/rainxch/core/domain/system/UpdateScheduleManager.ktcore/presentation/src/commonMain/composeResources/values/strings.xmlfeature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileAction.ktfeature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileRoot.ktfeature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileState.ktfeature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileViewModel.ktfeature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/components/sections/Installation.kt
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+235
to
+243
| private fun loadUpdateCheckInterval() { | ||
| viewModelScope.launch { | ||
| themesRepository.getUpdateCheckInterval().collect { hours -> | ||
| _state.update { | ||
| it.copy(updateCheckIntervalHours = hours) | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Validate interval values before persisting/rescheduling.
hours is currently trusted end-to-end. Please normalize to supported values (3/6/12/24) before writing state/repository and before scheduling.
Suggested hardening
+ private val supportedUpdateIntervals = setOf(3L, 6L, 12L, 24L)
+ private const val defaultUpdateIntervalHours = 6L
+
+ private fun normalizeUpdateInterval(hours: Long): Long =
+ hours.takeIf { it in supportedUpdateIntervals } ?: defaultUpdateIntervalHours
+
private fun loadUpdateCheckInterval() {
viewModelScope.launch {
themesRepository.getUpdateCheckInterval().collect { hours ->
+ val normalized = normalizeUpdateInterval(hours)
_state.update {
- it.copy(updateCheckIntervalHours = hours)
+ it.copy(updateCheckIntervalHours = normalized)
}
}
}
}
@@
is ProfileAction.OnUpdateCheckIntervalChanged -> {
+ val normalized = normalizeUpdateInterval(action.hours)
viewModelScope.launch {
- themesRepository.setUpdateCheckInterval(action.hours)
- updateScheduleManager.reschedule(action.hours)
+ themesRepository.setUpdateCheckInterval(normalized)
+ updateScheduleManager.reschedule(normalized)
}
}Also applies to: 418-423
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@feature/profile/presentation/src/commonMain/kotlin/zed/rainxch/profile/presentation/ProfileViewModel.kt`
around lines 235 - 243, Normalize and validate the incoming update-interval
value to the supported set {3,6,12,24} before you persist it, update _state, or
pass it to any scheduler: in loadUpdateCheckInterval() wrap the collected hours
from themesRepository.getUpdateCheckInterval().collect with a normalization
function (e.g., normalizeUpdateInterval(hours)) and use the normalized value
when calling _state.update and when any scheduling functions are invoked; do the
same in the code path that writes/updates the repository (the method that saves
the interval) and in the scheduler invocation (e.g., scheduleUpdateCheck or
similar) so all writes and scheduling always use the normalized value.
- Added string resources for update check intervals (3h, 6h, 12h, 24h) and a new "Updates" section across multiple languages (ko, pl, it, ja, fr, hi, bn, es, ar, zh-rCN, ru, tr). - Refactored self-app registration in `GithubStoreApp.kt` to improve code formatting. - Removed unused `Logger` imports and simplified exception handling during self-registration.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
core/presentation/src/commonMain/composeResources/values-tr/strings-tr.xml (1)
524-527: Consider using a clearer Turkish hour abbreviation for interval chips.At Line 524-527,
3s/6s/12s/24scan be ambiguous.sa(orsaat) is clearer and more consistent with Line 380 usage (sa).Suggested wording
- <string name="interval_3h">3s</string> - <string name="interval_6h">6s</string> - <string name="interval_12h">12s</string> - <string name="interval_24h">24s</string> + <string name="interval_3h">3 sa</string> + <string name="interval_6h">6 sa</string> + <string name="interval_12h">12 sa</string> + <string name="interval_24h">24 sa</string>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@core/presentation/src/commonMain/composeResources/values-tr/strings-tr.xml` around lines 524 - 527, The interval string values interval_3h, interval_6h, interval_12h and interval_24h use ambiguous 's' suffix; change their text to use the clearer Turkish hour abbreviation used elsewhere (e.g., "sa" or "saat") to match existing usage (see occurrences like the "sa" at line ~380) so that interval_3h, interval_6h, interval_12h and interval_24h become "3sa"/"6sa"/"12sa"/"24sa" (or "3 saat"/"6 saat"/"12 saat"/"24 saat") for consistency and clarity.composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt (1)
82-87: Consider adding error handling for scheduling failures.If
getUpdateCheckInterval()throws or the scheduling fails, the exception will be silently swallowed by the coroutine, leaving background update checks unscheduled without any indication.💡 Suggested improvement
private fun scheduleBackgroundUpdateChecks() { appScope.launch { - val intervalHours = get<ThemesRepository>().getUpdateCheckInterval().first() - UpdateScheduler.schedule(context = this@GithubStoreApp, intervalHours = intervalHours) + try { + val intervalHours = get<ThemesRepository>().getUpdateCheckInterval().first() + UpdateScheduler.schedule(context = this@GithubStoreApp, intervalHours = intervalHours) + } catch (e: Exception) { + co.touchlab.kermit.Logger.w(e) { "Failed to schedule background update checks" } + } } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt` around lines 82 - 87, The scheduleBackgroundUpdateChecks function currently launches a coroutine without error handling, so exceptions from get<ThemesRepository>().getUpdateCheckInterval() or UpdateScheduler.schedule(...) are swallowed; wrap the work inside appScope.launch with a try/catch around the await of getUpdateCheckInterval() and the call to UpdateScheduler.schedule, log or report the exception via an existing logger (or add one) and optionally fall back to a safe default interval or retry behavior; reference scheduleBackgroundUpdateChecks, getUpdateCheckInterval (ThemesRepository), UpdateScheduler.schedule, and appScope.launch when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt`:
- Around line 140-141: Replace the empty catch block that swallows exceptions
(catch (_: Exception) { }) in GithubStoreApp.kt with explicit handling: catch
the exception as a variable (e.g., catch (e: Exception)) and log it using
Android logging (e.g., Log.e("GithubStoreApp", "Failed while <contextual
action>", e)) or your app's logger, and consider any specific recovery
(fallback/default values or rethrow) appropriate for the operation where this
try/catch resides.
---
Nitpick comments:
In
`@composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt`:
- Around line 82-87: The scheduleBackgroundUpdateChecks function currently
launches a coroutine without error handling, so exceptions from
get<ThemesRepository>().getUpdateCheckInterval() or
UpdateScheduler.schedule(...) are swallowed; wrap the work inside
appScope.launch with a try/catch around the await of getUpdateCheckInterval()
and the call to UpdateScheduler.schedule, log or report the exception via an
existing logger (or add one) and optionally fall back to a safe default interval
or retry behavior; reference scheduleBackgroundUpdateChecks,
getUpdateCheckInterval (ThemesRepository), UpdateScheduler.schedule, and
appScope.launch when making the change.
In `@core/presentation/src/commonMain/composeResources/values-tr/strings-tr.xml`:
- Around line 524-527: The interval string values interval_3h, interval_6h,
interval_12h and interval_24h use ambiguous 's' suffix; change their text to use
the clearer Turkish hour abbreviation used elsewhere (e.g., "sa" or "saat") to
match existing usage (see occurrences like the "sa" at line ~380) so that
interval_3h, interval_6h, interval_12h and interval_24h become
"3sa"/"6sa"/"12sa"/"24sa" (or "3 saat"/"6 saat"/"12 saat"/"24 saat") for
consistency and clarity.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ac2c2e5f-a876-400e-ab3c-99acd7330078
📒 Files selected for processing (13)
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.ktcore/presentation/src/commonMain/composeResources/values-ar/strings-ar.xmlcore/presentation/src/commonMain/composeResources/values-bn/strings-bn.xmlcore/presentation/src/commonMain/composeResources/values-es/strings-es.xmlcore/presentation/src/commonMain/composeResources/values-fr/strings-fr.xmlcore/presentation/src/commonMain/composeResources/values-hi/strings-hi.xmlcore/presentation/src/commonMain/composeResources/values-it/strings-it.xmlcore/presentation/src/commonMain/composeResources/values-ja/strings-ja.xmlcore/presentation/src/commonMain/composeResources/values-ko/strings-ko.xmlcore/presentation/src/commonMain/composeResources/values-pl/strings-pl.xmlcore/presentation/src/commonMain/composeResources/values-ru/strings-ru.xmlcore/presentation/src/commonMain/composeResources/values-tr/strings-tr.xmlcore/presentation/src/commonMain/composeResources/values-zh-rCN/strings-zh-rCN.xml
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt
Outdated
Show resolved
Hide resolved
- Replace hardcoded `SELF_PACKAGE_NAME` with the dynamic `packageName` property. - Update `SELF_AVATAR_URL` to point to the official repository app icon. - Integrate `kermit` logging to track self-registration success, warnings, and errors. - Add a null check for `systemInfo` to prevent registration if package info is missing. - Add `touchlab.kermit` dependency to `composeApp/build.gradle.kts`.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
composeApp/build.gradle.kts (1)
92-93: Optional cleanup: remove duplicate dependency.
libs.koin.compose.viewmodelis declared twice injvmMain.dependencies. Since you're modifying this file, consider removing the duplicate.♻️ Suggested fix
implementation(libs.koin.compose) implementation(libs.koin.compose.viewmodel) - implementation(libs.koin.compose.viewmodel)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@composeApp/build.gradle.kts` around lines 92 - 93, There is a duplicate dependency declaration for libs.koin.compose.viewmodel in the jvmMain dependencies block; remove the redundant implementation(libs.koin.compose.viewmodel) entry so the dependency appears only once (keep a single implementation(libs.koin.compose.viewmodel) line in the jvmMain.dependencies section) and re-sync / rebuild to verify no duplicates remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt`:
- Around line 84-87: The app startup coroutine launching scheduler
(appScope.launch) can throw from the DataStore read
get<ThemesRepository>().getUpdateCheckInterval().first() or
UpdateScheduler.schedule(...) and must be wrapped in a local try-catch to
prevent uncaught exceptions from bubbling; modify the GithubStoreApp startup
block to catch Throwable, log the failure using Logger (same pattern as
registerSelfAsInstalledApp()), and provide a safe fallback (skip scheduling) so
the app continues running if reading interval or scheduling fails.
- Around line 143-146: The success log in the try block currently uses Logger.e
which is for errors; update the success statement in the GithubStoreApp code
(where "GitHub Store App: App added" is logged) to use a non-error level such as
Logger.i or Logger.d instead, leaving the catch block's Logger.e("GitHub Store
App", e) unchanged so exceptions still log at error level.
---
Nitpick comments:
In `@composeApp/build.gradle.kts`:
- Around line 92-93: There is a duplicate dependency declaration for
libs.koin.compose.viewmodel in the jvmMain dependencies block; remove the
redundant implementation(libs.koin.compose.viewmodel) entry so the dependency
appears only once (keep a single implementation(libs.koin.compose.viewmodel)
line in the jvmMain.dependencies section) and re-sync / rebuild to verify no
duplicates remain.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: efb12599-9699-484a-b94f-b09a413927d1
📒 Files selected for processing (2)
composeApp/build.gradle.ktscomposeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt
Show resolved
Hide resolved
composeApp/src/androidMain/kotlin/zed/rainxch/githubstore/app/GithubStoreApp.kt
Outdated
Show resolved
Hide resolved
…toreApp` - Added a try-catch block to `scheduleBackgroundUpdateChecks` to handle and log potential failures during update scheduling. - Replaced the hardcoded `0L` repository ID with a new `SELF_REPO_ID` constant in `registerSelfAsInstalledApp`. - Refined logging in `registerSelfAsInstalledApp`, changing the success message to info level and improving the error log format.
This was referenced Mar 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UpdateScheduleManager and its Android and Desktop implementations
Summary by CodeRabbit
New Features
Platform
Localization