Conversation
… shell fallback Agent-Logs-Url: https://github.com/OpenIdentityPlatform/OpenDJ/sessions/7f513901-fae9-4dfc-ad62-a2f5e56df4e7 Co-authored-by: vharseko <6818498+vharseko@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CDDL header to Dockerfile and remove ROOT_PASSWORD environment variable
Remove ENV ROOT_PASSWORD from Dockerfiles, fix HEALTHCHECK default, add CDDL headers
Apr 10, 2026
This was referenced Apr 10, 2026
…un.sh (#635) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vharseko <6818498+vharseko@users.noreply.github.com>
…alpine jobs (#634) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vharseko <6818498+vharseko@users.noreply.github.com>
maximthomas
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENV ROOT_PASSWORD="password"in both Dockerfiles triggers the Docker lint ruleSecretsUsedInArgOrEnv. Removing it breaks theHEALTHCHECKbecause Docker daemon spawns that process independently — it does not inheritexports fromrun.sh, onlyENVinstructions and-eflags fromdocker run.Changes
Dockerfile/Dockerfile-alpineENV ROOT_PASSWORD="password"; replace with explanatory commentHEALTHCHECKto use shell parameter expansion so it works with or without-e ROOT_PASSWORD:--bindPassword "${ROOT_PASSWORD:-password}"run.shBehaviour
run.shsetsdocker run(no-e)password(shell fallback)passworddocker run -e ROOT_PASSWORD=secretsecretsecretOriginal prompt
Problem
Both
opendj-packages/opendj-docker/Dockerfileandopendj-packages/opendj-docker/Dockerfile-alpinehaveENV ROOT_PASSWORD="password"which triggers the Docker lint warning:Required Changes
1.
opendj-packages/opendj-docker/DockerfileAdd CDDL header at the top (same style as https://github.com/OpenIdentityPlatform/OpenIDM/blob/1df435f73a70f50e51a99c1623b64da01c88bc0b/Dockerfile):
Remove line 11 (
ENV ROOT_PASSWORD="password") and replace with a comment:Change the HEALTHCHECK line (currently line 53) from:
to:
The key change is
$ROOT_PASSWORD→"${ROOT_PASSWORD:-password}"so the shell fallback provides the default when the variable is not set via-e.2.
opendj-packages/opendj-docker/Dockerfile-alpineAdd the same CDDL header at the top:
Same changes as Dockerfile: remove
ENV ROOT_PASSWORD="password", replace with comment, fix HEALTHCHECK with"${ROOT_PASSWORD:-password}".3.
opendj-packages/opendj-docker/run.shAdd CDDL copyright notice right after the shebang line. The file already has comments starting at line 2. Add the CDDL header after the shebang but before the existing comments. Since this is a modification of an existing file, use "Portions copyright":
Keep
run.shlogic exactly as the original master version (do NOT add Docker secrets support). The current master content of run.sh lines 31-32 is:This must remain unchanged. Do not add any
/run/secrets/root_passwordlogic.Summary of all changes
opendj-packages/opendj-docker/DockerfileENV ROOT_PASSWORD="password"(replace with comment), fix HEALTHCHECK to use...This pull request was created from Copilot chat.