removed TARGET_SYSTEM_PROP, edit TARGET_COPY_OUT_VENDOR#2
Open
DigiGoon wants to merge 1 commit intoOpenKirin:7.xfrom
DigiGoon:patch-1
Open
removed TARGET_SYSTEM_PROP, edit TARGET_COPY_OUT_VENDOR#2DigiGoon wants to merge 1 commit intoOpenKirin:7.xfrom DigiGoon:patch-1
DigiGoon wants to merge 1 commit intoOpenKirin:7.xfrom
DigiGoon:patch-1
Conversation
DigiGoon
commented
Aug 17, 2017
DigiGoon
commented
- no need for TARGET_SYSTEM_PROP after 7.x
- vendor is built as separate image, so no need to cook it into system/vendor
1. no need for TARGET_SYSTEM_PROP after 7.x 2. vendor is built as separate image, so no need to cook it into system/vendor
Huawei-Dev
reviewed
Aug 26, 2017
Huawei-Dev
left a comment
Huawei-Dev
left a comment
There was a problem hiding this comment.
we don't want to build vendor, as we use a prebuild one, so we still need "TARGET_COPY_OUT_VENDOR := system"
Author
|
So it should be "TARGET_COPY_OUT_VENDOR := system/vendor" no? |
|
I did not understand what problems you are experiencing if you keep : TARGET_COPY_OUT_VENDOR := system ? |
Author
|
Some ROMs like halogenOS needs it to be either system/vendor or just vendor. |
abdigholami4286
approved these changes
Feb 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.