[for 0.10] Remove EPoll delay#1802
Merged
peternewman merged 4 commits intoOpenLightingProject:0.10from Dec 6, 2022
Merged
Conversation
peternewman
requested changes
Dec 5, 2022
Member
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Thanks @DaAwesomeP , but could we just have the changes to EPoller.cpp in here, not the test program too please.
Member
Author
|
@peternewman Fixed! |
peternewman
changed the title
peternewman
approved these changes
Dec 6, 2022
Member
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
LGTM thanks @DaAwesomeP .
Feel free to add yourself to AUTHORS too:
https://github.com/OpenLightingProject/ola/blob/0.10/AUTHORS
Member
Author
Adding! One moment please. |
Member
Author
|
Done! |
Member
|
Sorry can you pull 0.10 or rebase too as I snuck another commit in there! |
Member
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-picked duplicate of #1801 for v0.10.
Possible milestone #1792
cc @peternewman