Skip to content

More RDM Responder tests#1999

Open
peternewman wants to merge 18 commits intoOpenLightingProject:masterfrom
peternewman:plugfest
Open

More RDM Responder tests#1999
peternewman wants to merge 18 commits intoOpenLightingProject:masterfrom
peternewman:plugfest

Conversation

@peternewman
Copy link
Copy Markdown
Member

No description provided.

@peternewman peternewman added this to the 0.11.0 milestone Mar 11, 2025
@peternewman peternewman requested a review from kripton March 11, 2025 00:55
Copy link
Copy Markdown
Contributor

@aroffringa aroffringa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me although I struggle with the context of the code. You're introducing a few 'const string' parameter which I suspect would be better to be reference types; I've marked those.

@peternewman
Copy link
Copy Markdown
Member Author

Looks ok to me although I struggle with the context of the code.

The C++ (or both languages), which bit or bits (or all of it) and I can try and give a bit more background.

You're introducing a few 'const string' parameter which I suspect would be better to be reference types; I've marked those.

Sorry I realised I should have taken your suggestions directly, although we've typically styled them slightly differently.

@aroffringa
Copy link
Copy Markdown
Contributor

Looks ok to me although I struggle with the context of the code.

The C++ (or both languages), which bit or bits (or all of it) and I can try and give a bit more background.

I'm not familiar with all parts of the code (yet :D). I'll try to slowly read up more what's happening where. For now I think it's all good -- I think it's fine to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants