More RDM Responder tests#1999
More RDM Responder tests#1999peternewman wants to merge 18 commits intoOpenLightingProject:masterfrom
Conversation
… if it's an ESTA PID OLA doesn't know about
aroffringa
left a comment
There was a problem hiding this comment.
Looks ok to me although I struggle with the context of the code. You're introducing a few 'const string' parameter which I suspect would be better to be reference types; I've marked those.
The C++ (or both languages), which bit or bits (or all of it) and I can try and give a bit more background.
Sorry I realised I should have taken your suggestions directly, although we've typically styled them slightly differently. |
I'm not familiar with all parts of the code (yet :D). I'll try to slowly read up more what's happening where. For now I think it's all good -- I think it's fine to merge. |
No description provided.