Skip to content

E1.20 2025 Updates#2004

Merged
peternewman merged 4 commits intoOpenLightingProject:masterfrom
peternewman:e1.20-2025
Apr 4, 2026
Merged

E1.20 2025 Updates#2004
peternewman merged 4 commits intoOpenLightingProject:masterfrom
peternewman:e1.20-2025

Conversation

@peternewman
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@kripton kripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

case UNITS_DECIBEL_WATT:
return "dB(W)";
case UNITS_DECIBEL_METER:
return "dB meter";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be "dBm"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wikipedia has:

dBm or dBmW (decibel-milliwatts)

https://en.wikipedia.org/wiki/DBm

Also:

Attenuation (loss) per unit length, in decibels per metre

https://en.wikipedia.org/wiki/Coaxial_cable#Derived_electrical_parameters

For added complication, it was designed for use with Table A12's SENS_LOG_RATIO_METER which either got taken out of, or never made it into that table, so there's nothing else to work with either.

There's also nothing on:
https://en.wikipedia.org/wiki/Decibel

I wonder if it was supposed to be per meter.

Obviously the whole meter/metre thing makes searching for more info nearly impossible...

case UNITS_PERCENT:
return "%";
case UNITS_MOLES_PER_METER_CUBED:
return "mol/m^3";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have full UTF-8 support, we could do mol/m³

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've not done so with e.g.

return "m^2";
so I think it's a future enhancement...

Added comments to remind developers to update related files when adding new data types.
@peternewman peternewman marked this pull request as ready for review April 4, 2026 12:19
@peternewman peternewman merged commit 1995016 into OpenLightingProject:master Apr 4, 2026
8 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants