Conversation
OpenMS core library now uses libcurl instead of Qt Network for HTTP operations. Add the development packages so the build can find curl headers and libraries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add CMAKE_POSITION_INDEPENDENT_CODE=ON to the curl cmake configuration. Without this, the static libcurl.a contains position-dependent relocations (R_X86_64_32S) that cannot be linked into libOpenMS.so, causing linker failures on Linux wheel builds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adds build dependencies for curl support by introducing the libcurl development package to the Docker image and enabling position-independent code compilation in the CMake curl build configuration, supporting curl integration in the project. Changes
Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit