Fix Python site-packages path in Windows build cleanup#13
Fix Python site-packages path in Windows build cleanup#13t0mdavid-m wants to merge 1 commit intomainfrom
Conversation
The "Clean up unnecessary Python files" step referenced "py/Lib/site-packages" but the embeddable Python is extracted to "python-$PYTHON_VERSION/Lib/site-packages". https://claude.ai/code/session_01Wec3EbnZWp4J89xc3EMxyU
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Windows executable build workflow cleanup step is updated to reference the embeddable Python installation path instead of the legacy path, targeting Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Updated the Windows executable build workflow to use the correct Python site-packages directory path that includes the Python version number.
Changes
$sitePkgsvariable in the cleanup step to referencepython-${{ env.PYTHON_VERSION }}/Lib/site-packagesinstead of the hardcodedpy/Lib/site-packagespathDetails
The previous hardcoded path
py/Lib/site-packagesdid not match the actual directory structure created during the build, which uses a versioned directory name likepython-3.11/Lib/site-packages. By using thePYTHON_VERSIONenvironment variable, the cleanup step will now correctly locate and remove unnecessary Python files (pycache directories, etc.) from the appropriate location.https://claude.ai/code/session_01Wec3EbnZWp4J89xc3EMxyU
Summary by CodeRabbit