Skip to content

Fix Python site-packages path in Windows build cleanup#13

Open
t0mdavid-m wants to merge 1 commit intomainfrom
claude/fix-powershell-directory-listing-FSzRK
Open

Fix Python site-packages path in Windows build cleanup#13
t0mdavid-m wants to merge 1 commit intomainfrom
claude/fix-powershell-directory-listing-FSzRK

Conversation

@t0mdavid-m
Copy link
Member

@t0mdavid-m t0mdavid-m commented Mar 5, 2026

Summary

Updated the Windows executable build workflow to use the correct Python site-packages directory path that includes the Python version number.

Changes

  • Modified the $sitePkgs variable in the cleanup step to reference python-${{ env.PYTHON_VERSION }}/Lib/site-packages instead of the hardcoded py/Lib/site-packages path
  • This ensures the cleanup script correctly targets the actual Python installation directory structure used in the build process

Details

The previous hardcoded path py/Lib/site-packages did not match the actual directory structure created during the build, which uses a versioned directory name like python-3.11/Lib/site-packages. By using the PYTHON_VERSION environment variable, the cleanup step will now correctly locate and remove unnecessary Python files (pycache directories, etc.) from the appropriate location.

https://claude.ai/code/session_01Wec3EbnZWp4J89xc3EMxyU

Summary by CodeRabbit

  • Chores
    • Updated Windows build process configuration to target the correct Python installation directory for cleanup operations.

The "Clean up unnecessary Python files" step referenced "py/Lib/site-packages"
but the embeddable Python is extracted to "python-$PYTHON_VERSION/Lib/site-packages".

https://claude.ai/code/session_01Wec3EbnZWp4J89xc3EMxyU
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a8bf2301-b71e-4f46-ae4a-79cbd970f923

📥 Commits

Reviewing files that changed from the base of the PR and between a271efb and c63b5ec.

📒 Files selected for processing (1)
  • .github/workflows/build-windows-executable-app.yaml

📝 Walkthrough

Walkthrough

The Windows executable build workflow cleanup step is updated to reference the embeddable Python installation path instead of the legacy path, targeting python-${{ env.PYTHON_VERSION }}/Lib/site-packages for pycache and test file removal.

Changes

Cohort / File(s) Summary
Windows Build Workflow
.github/workflows/build-windows-executable-app.yaml
Updated cleanup step to target embeddable Python path (python-${{ env.PYTHON_VERSION }}/Lib/site-packages) instead of legacy path (py/Lib/site-packages) for site-packages cleanup.

Poem

🐰 A path once old now finds its way,
From dusty py to modern day,
The Python version takes its place,
Workflows clean with fresher grace! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the Python site-packages path in the Windows build cleanup workflow, which aligns with the actual file modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-powershell-directory-listing-FSzRK

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants