fix: remove hardcoded CPU device in VLM_COCO_Local#2468
Open
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Open
fix: remove hardcoded CPU device in VLM_COCO_Local#2468Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Wanbogang wants to merge 2 commits intoOpenMind:mainfrom
Conversation
VLM_COCO_Local had self.device hardcoded to 'cpu', preventing GPU utilization even when CUDA is available. This fix auto-detects the optimal device at initialization and logs the selected device. - Replace hardcoded 'cpu' with torch.cuda.is_available() check - Add logging to show which device is selected at startup - Update tests to mock GPU detection for consistent CI behavior
33920c1 to
a50f4c8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VLM_COCO_Localhadself.devicehardcoded to"cpu", which meansGPU was never utilized even when CUDA is available. This caused
unnecessarily slow local inference on machines with a dedicated GPU.
Solution
Replace the hardcoded value with automatic device detection using
PyTorch's built-in
torch.cuda.is_available():Changes
src/inputs/plugins/vlm_coco_local.py— replace hardcoded"cpu"with auto-detectiontests/inputs/plugins/test_vlm_coco_local.py— mocktorch.cuda.is_available()to ensure consistent CI behavior regardless of hardware