Skip to content

do not write data twice to override file in linearize() #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeas31 merged 2 commits into from
Apr 15, 2026
Merged

do not write data twice to override file in linearize() #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a028f
do not write data twice to override file in linearize()
syntron Apr 14, 2026
f30dc3f
fix flake8
syntron Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions OMPython/ModelicaSystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ def simulate_cmd(
major, minor, patch = self.parse_om_version(self._version)
if (major, minor, patch) >= (1, 26, 0):
for key, opt_value in self._simulate_options_override.items():
k = "s" if key=="solver" else key
k = "s" if key == "solver" else key
om_cmd.arg_set(key=k, val=str(opt_value))
override_content = (
"\n".join([f"{key}={value}" for key, value in self._override_variables.items()])
Expand Down Expand Up @@ -1683,12 +1683,6 @@ def linearize(
override_file = self.getWorkDirectory() / f'{self._model_name}_override_linear.txt'
override_file.write_text(override_content)

with open(file=override_file, mode="w", encoding="utf-8") as fh:
for key1, value1 in self._override_variables.items():
fh.write(f"{key1}={value1}\n")
for key2, value2 in self._linearization_options.items():
fh.write(f"{key2}={value2}\n")

om_cmd.arg_set(key="overrideFile", val=override_file.as_posix())

if self._inputs:
Expand Down
Loading