[com1] Add additional input options for rheological models#1254
Merged
[com1] Add additional input options for rheological models#1254
Conversation
Contributor
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Contributor
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Components (1)
Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
fso42
requested changes
Mar 19, 2026
PaulaSp3
requested changes
Mar 19, 2026
fso42
approved these changes
Mar 19, 2026
PaulaSp3
requested changes
Mar 19, 2026
JuLa96
force-pushed
the
JL_AdditionalInputOptionsForRheologicalModels
branch
from
24d9546 to
51a32ed
Compare
PaulaSp3
approved these changes
Mar 20, 2026
Update DFAfunctionsCython.pyx Additional input options for rheological models Add additional input option for Herschel-Bulkley Update theoryCom1DFA.rst Update theoryCom1DFA.rst due to changes in input options for the rheological models Update com1DFACfg.ini due to changes in input options for the rheological models Update test_DFAfunctionsCython.py due to changes in input options for the rheological models Update checkCfg.py due to changes in input options for rheological models qlty fmt
fso42
force-pushed
the
JL_AdditionalInputOptionsForRheologicalModels
branch
from
7f08295 to
36b2ba5
Compare
Contributor
|
Standardtests ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An additional parameter input option has been introduced for the Bingham, Herschel and Bulkley and O'Brien and Julien rheological models, making it possible to define the yield shear stress
tauyand the dynamic viscosityetadirectly in the configuration file.By default,
tauyandetaare used directly from the configuration file. If either of these two parameters is set to 0, the quantities are computed usingalpha,betaandcv.See issue: OpenNHM/DebrisFrame#61