NMS-19451: Running Core, Sentinel and Minion using JDK21#8262
NMS-19451: Running Core, Sentinel and Minion using JDK21#8262christianpape merged 8 commits intodevelopfrom
Conversation
christianpape
requested review from
cgorantla,
indigo423 and
synqotik
and removed request for
mershad-manesh
indigo423
left a comment
indigo423
left a comment
There was a problem hiding this comment.
Had it running for a while with Kafka and a Minion and haven't seen any issues so far.
indigo423
force-pushed
the
jira/NMS-19451
branch
from
81ecb6e to
7a21502
Compare
There was a problem hiding this comment.
Had it running for a while with Kafka and a Minion and haven't seen any issues so far.
@christianpape I've updated the branch and resolved the conflicts so it is mergeable again.
Signed-off-by: Ronny Trommer <ronny@no42.org>
indigo423
left a comment
indigo423
left a comment
There was a problem hiding this comment.
Had it running for a while with Kafka and a Minion and haven't seen any issues so far.
|
I've tested this branch with:
|
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Great work @christianpape !
Couple of nits. Otherwise LGTM!
christianpape
dismissed stale reviews from cgorantla and indigo423
via
76df1c4
@indigo423 Have you got a chance to test HTTPS stuff on this branch ? That's the main thing we need to confirm. |
|
@christianpape @cgorantla tested it with Jetty and self-signed certificates and haven't seen any issues. 
|
indigo423
left a comment
indigo423
left a comment
There was a problem hiding this comment.
Haven't seen any issues so far.
3 participants
This PR ensures that OpenNMS Core, Sentinel, and Minion can run with JDK21. The integration tests and smoke tests are green, but nothing else has been tested so far. Therefore, I kindly request everyone to test this branch extensively.