[CI FIX]: remove the use of pkg_resources#120
Open
TenzDelek wants to merge 1 commit intoOpenPecha:masterfrom
Open
[CI FIX]: remove the use of pkg_resources#120TenzDelek wants to merge 1 commit intoOpenPecha:masterfrom
pkg_resources#120TenzDelek wants to merge 1 commit intoOpenPecha:masterfrom
Conversation
Member
Author
|
CI Should work as expected. PTAL @eroux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #119
Problem
setuptools 82+ removed
pkg_resourcespypa/setuptools#5174, which broke our CI. Our setup.py imported it to assertsetuptools >= 38.6.0.Solution:
Removed the assertion. It was a safeguard from 2017 when
long_description_content_typewas new.Today, setuptools is in the 80+ range and pip itself requires a much newer version so The check would never fail in practice. current code was kind of deadcode