Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea759e17b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Install dependencies (Linux) | ||
| if: matrix.os == 'ubuntu-latest' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libcups2-dev |
There was a problem hiding this comment.
In the ubuntu-latest job this only installs libcups2-dev; it never starts cupsd or creates a printer. Every integration test in tests/integration_tests.rs is gated by cups_available(), which returns immediately unless get_all_destinations() can talk to a real destination, so the Linux leg will go green while the printer/job integration coverage is skipped entirely. That means CI will miss regressions in the core CUPS workflows this crate wraps.
Useful? React with 👍 / 👎.
1 participant
Adds a CI workflow using GitHub Actions to build and test the project on each push and pull request.
The workflow:
• builds the project using cargo build
• runs tests using cargo test