Add OAuth bearer auth-info support (#1233)#1425
Open
Swastik092 wants to merge 3 commits intoOpenPrinting:masterfrom
Open
Add OAuth bearer auth-info support (#1233)#1425Swastik092 wants to merge 3 commits intoOpenPrinting:masterfrom
Swastik092 wants to merge 3 commits intoOpenPrinting:masterfrom
Conversation
Member
|
Fantastic, thanks for tackling this! ATM I am trying to fix the CI server tests, but once that is finished up I will get to reviewing this and providing feedback! |
| IPP_TAG_NAME)) != NULL) | ||
| { | ||
| value[0] = '\0'; | ||
| for (i = 0, ptr = value; i < attr->num_values; i ++) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| */ | ||
|
|
||
| snprintf(attr_name, sizeof(attr_name), "%s-default", option->keyword); | ||
| for (i = 0; attr_name[i]; i ++) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| * Skip options that are already explicitly handled... | ||
| */ | ||
|
|
||
| if (!strcmp(option->keyword, "PageSize") || |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
inthesquarehole
left a comment
inthesquarehole
left a comment
There was a problem hiding this comment.
I didn't check whether it compiles, but otherwise this seems very useful to many organizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end-to-end OAuth Bearer support for shared queues: the scheduler now understands the
bearerauth-info keyword, advertises the OAuth metadata via DNS-SD and destination data, and persists bearer tokens. The IPP backend requests the new attributes, honorsWWW-Authenticate: Bearer, and forwardsAUTH_BEARERtokens. Docs and man pages were updated, and the change is recorded inCHANGES.md.