Services Discovery Functionality#389
Open
TheJayas wants to merge 1 commit intoOpenPrinting:masterfrom
Open
Conversation
zdohnal
requested changes
Feb 13, 2025
Member
zdohnal
left a comment
zdohnal
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Please check my comment and do let me know what do you think - IMO we call Avahi there as well, so if the module is missing, we get traceback, so we should check the AVAHI_AVAILABLE again.
Thank you in advance!
|
|
||
| self.PrintersWindow.show() | ||
| self.builder = Gtk.Builder() | ||
| self.service_browser = AvahiServiceBrowser() |
Member
There was a problem hiding this comment.
Shouldn't these three lines be guarded by AVAHI_AVAILABLE as well? We call objects from Avahi at the method run().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @tillkamppeter and @zdohnal , I have created new pull request with all the changes required by you. Please look into it and suggest if any other changes are required.