Skip to content

fix(spp_registry): disable gender creation in individual form #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzalesedwin1123 merged 1 commit into from
Feb 12, 2026
+1 −1
Merged

fix(spp_registry): disable gender creation in individual form #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spp_registry/views/individual_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
<field name="birthdate" readonly="disabled" help="Date of Birth - mm/dd/yyyy" />
</group>
<group>
<field name="gender_id" readonly="disabled" />
<field name="gender_id" readonly="disabled" options="{'no_create': True, 'no_open': True}" />
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To fully disable creation options as intended, it's best to also include no_create_edit: True. The PR description mentions verifying that 'Create and Edit' is not available, and this option is what controls that feature in the dropdown menu. For consistency with other vocabulary-based fields in this file, such as id_type_id on line 303, which uses {'no_open':True,'no_create_edit':True,'no_create':True}, adding this option would be beneficial.

Suggested change
<field name="gender_id" readonly="disabled" options="{'no_create': True, 'no_open': True}" />
<field name="gender_id" readonly="disabled" options="{'no_create': True, 'no_create_edit': True, 'no_open': True}" />

</group>
<group>
<field name="age" />
Expand Down
Loading