Skip to content

fix(spp_change_request_v2): add no_create/no_open to lookup fields in CR detail views #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzalesedwin1123 merged 1 commit into from
Feb 12, 2026
Merged

fix(spp_change_request_v2): add no_create/no_open to lookup fields in CR detail views #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions spp_change_request_v2/views/detail_add_member_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,14 @@
</group>
<group>
<field name="birthdate" />
<field name="gender_id" />
<field name="relationship_id" />
<field
name="gender_id"
options="{'no_create': True, 'no_open': True}"
/>
<field
name="relationship_id"
options="{'no_create': True, 'no_open': True}"
/>
</group>
</group>

Expand Down
2 changes: 1 addition & 1 deletion spp_change_request_v2/views/detail_change_hoh_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<group string="Previous Head Reassignment">
<field
name="previous_head_new_role_id"
options="{'no_create': True}"
options="{'no_create': True, 'no_open': True}"
/>
</group>
</group>
Expand Down
8 changes: 4 additions & 4 deletions spp_change_request_v2/views/detail_create_group_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<group>
<group string="Group Information">
<field name="group_name" required="1" />
<field name="group_type_id" options="{'no_create': True}" />
<field name="group_type_id" options="{'no_create': True, 'no_open': True}" />
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other views in this PR (e.g., detail_add_member_views.xml), it would be better to format this field over multiple lines, with one attribute per line. This improves readability and makes future diffs cleaner.

Suggested change
<field name="group_type_id" options="{'no_create': True, 'no_open': True}" />
<field
name="group_type_id"
options="{'no_create': True, 'no_open': True}"
/>

</group>
<group string="Contact">
<field name="phone" />
Expand Down Expand Up @@ -61,7 +61,7 @@
<field name="head_birthdate" />
<field
name="head_gender_id"
options="{'no_create': True}"
options="{'no_create': True, 'no_open': True}"
/>
<field name="head_phone" />
</group>
Expand All @@ -75,9 +75,9 @@
<field name="city" />
</group>
<group>
<field name="state_id" options="{'no_create': True}" />
<field name="state_id" options="{'no_create': True, 'no_open': True}" />
<field name="postal_code" />
<field name="country_id" options="{'no_create': True}" />
<field name="country_id" options="{'no_create': True, 'no_open': True}" />
Comment on lines +78 to +80
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other views in this PR (e.g., detail_add_member_views.xml), it would be better to format these fields over multiple lines, with one attribute per line. This improves readability and makes future diffs cleaner.

                            <field
                                name="state_id"
                                options="{'no_create': True, 'no_open': True}"
                            />
                            <field name="postal_code" />
                            <field
                                name="country_id"
                                options="{'no_create': True, 'no_open': True}"
                            />

</group>
</group>

Expand Down
5 changes: 4 additions & 1 deletion spp_change_request_v2/views/detail_edit_individual_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@
<field name="given_name" required="1" />
<field name="family_name" required="1" />
<field name="birthdate" />
<field name="gender_id" />
<field
name="gender_id"
options="{'no_create': True, 'no_open': True}"
/>
</group>
<group>
<field name="phone" />
Expand Down
1 change: 1 addition & 0 deletions spp_change_request_v2/views/detail_exit_registrant_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<field
name="destination_country_id"
invisible="exit_reason != 'emigrated'"
options="{'no_create': True, 'no_open': True}"
/>
</group>
<group string="Options">
Expand Down
6 changes: 5 additions & 1 deletion spp_change_request_v2/views/detail_merge_registrants_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@

<group>
<group string="Primary Registrant (Keep)">
<field name="primary_registrant_id" required="1" />
<field
name="primary_registrant_id"
required="1"
options="{'no_create': True, 'no_open': True}"
/>
<field name="primary_name" invisible="1" />
<field name="is_group_merge" invisible="1" />
<field name="available_duplicate_ids" invisible="1" />
Expand Down
12 changes: 8 additions & 4 deletions spp_change_request_v2/views/detail_split_household_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@

<group>
<group string="Source Household">
<field name="source_group_id" required="1" />
<field
name="source_group_id"
required="1"
options="{'no_create': True, 'no_open': True}"
/>
<field name="source_group_name" invisible="1" />
<field name="available_member_ids" invisible="1" />
<field name="members_to_split_ids" invisible="1" />
Expand Down Expand Up @@ -89,7 +93,7 @@
<field name="new_group_name" required="1" />
<field
name="new_group_type_id"
options="{'no_create': True}"
options="{'no_create': True, 'no_open': True}"
/>
</group>
<group>
Expand All @@ -104,9 +108,9 @@
<field name="city" />
</group>
<group string="Location">
<field name="state_id" options="{'no_create': True}" />
<field name="state_id" options="{'no_create': True, 'no_open': True}" />
<field name="postal_code" />
<field name="country_id" options="{'no_create': True}" />
<field name="country_id" options="{'no_create': True, 'no_open': True}" />
Comment on lines +111 to +113
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other views in this PR (e.g., detail_add_member_views.xml), it would be better to format these fields over multiple lines, with one attribute per line. This improves readability and makes future diffs cleaner.

                            <field
                                name="state_id"
                                options="{'no_create': True, 'no_open': True}"
                            />
                            <field name="postal_code" />
                            <field
                                name="country_id"
                                options="{'no_create': True, 'no_open': True}"
                            />

</group>
<group string="Contact">
<field name="phone" />
Expand Down
7 changes: 5 additions & 2 deletions spp_change_request_v2/views/detail_transfer_member_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
<sheet>
<group>
<group string="Source">
<field name="source_group_id" />
<field
name="source_group_id"
options="{'no_create': True, 'no_open': True}"
/>
<field name="available_individual_ids" invisible="1" />
<field
name="individual_id"
Expand All @@ -47,7 +50,7 @@
options="{'no_create': True}"
required="1"
/>
<field name="new_role_id" options="{'no_create': True}" />
<field name="new_role_id" options="{'no_create': True, 'no_open': True}" />
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other views in this PR (e.g., detail_add_member_views.xml), it would be better to format this field over multiple lines, with one attribute per line. This improves readability and makes future diffs cleaner.

                            <field
                                name="new_role_id"
                                options="{'no_create': True, 'no_open': True}"
                            />

</group>
</group>
<group>
Expand Down
2 changes: 1 addition & 1 deletion spp_change_request_v2/views/detail_update_id_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
</group>
<group invisible="operation == 'remove'">
<group string="ID Information">
<field name="id_type_id" options="{'no_create': True}" />
<field name="id_type_id" options="{'no_create': True, 'no_open': True}" />
Copy link

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other views in this PR (e.g., detail_add_member_views.xml), it would be better to format this field over multiple lines, with one attribute per line. This improves readability and makes future diffs cleaner.

                            <field
                                name="id_type_id"
                                options="{'no_create': True, 'no_open': True}"
                            />

<field name="id_value" required="operation == 'add'" />
<field name="expiry_date" />
</group>
Expand Down
Loading