Skip to content

reference legacy GHA internal call like external #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarasvoss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reference legacy GHA internal call like external #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tf_validate_plan_env_roots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
jobs:
TF-Validate-Plan-Roots:
name: TF Validate/Plan ENV Roots
uses: ./.github/workflows/tf_validate_plan_single_root.yml
uses: OpenSesame/core-github-actions/.github/workflows/tf_validate_plan_single_root.yml@legacy-stable
strategy:
fail-fast: false # continues to run jobs even if one fails
Comment on lines 33 to 37
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job now calls a reusable workflow via uses: but the workflow doesn't declare permissions. Other callers (e.g., .github/workflows/deploy_environment.yml) explicitly grant id-token: write for the Terraform plan workflow; without equivalent permissions here, the called workflow may not be able to request an OIDC token (common failure when using aws-actions/configure-aws-credentials). Consider adding an explicit permissions block (at least id-token: write and contents: read) to this workflow or to the TF-Validate-Plan-Roots job so token permissions are well-defined for downstream callers.

Copilot uses AI. Check for mistakes.
matrix:
Expand Down
42 changes: 19 additions & 23 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading