VideoCacheThread: Add Directional Pre-roll#1032
Open
Conversation
- start cache rebuilds with a preroll offset (settings-based) - tighten isReady to require frames ahead/behind playhead add unit tests for preroll clamping and readiness
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1032 +/- ##
========================================
Coverage 59.60% 59.60%
========================================
Files 206 206
Lines 20374 20472 +98
========================================
+ Hits 12143 12202 +59
- Misses 8231 8270 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
- add adaptive seek fallback and switch fprintf to ZmqLogger - improves seeking on certain files by up to 30% (faster) - avoids situations where seeking too far would sometimes freeze on certain videos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary idea is to cache "some" small amount of frames (30) prior to the playhead or seek position, to allow cached access to "before playhead" frames without busting cache. This seems to be a common issue on a video editor, where seeing to a spot, and then needing to go forwards and backwards quickly around this position without busting and clearing the entire cache.