Fix CRs for paragraphs with empty first line#5340
Open
bastianjoel wants to merge 33 commits intoOpenSlides:mainfrom
Open
Fix CRs for paragraphs with empty first line#5340bastianjoel wants to merge 33 commits intoOpenSlides:mainfrom
bastianjoel wants to merge 33 commits intoOpenSlides:mainfrom
Conversation
3 tasks
Member
|
Do not merge yet |
Elblinator
approved these changes
Aug 27, 2025
Member
|
Please reassign me if approved |
luisa-beerboom
approved these changes
Aug 28, 2025
ed0db4d to
22867e2
Compare
|
Found two issue during testing. Already talked with @bastianjoel about it. Full review follows. Need more test data.
|
Member
Author
|
@MSoeb The requested changes are fixed now. |
MSoeb
requested changes
Jan 20, 2026
There was a problem hiding this comment.
Found two Issues:
Projections of motions not possible (I guess it's because of the new projector service)-> projection have their own repository nowFound a failure in relation to issue #5165 . If I build a motion in the mentioned way and create a change recommendation to line one, two empty lines appears in the CR editor. The motion in normal view and the edtior of the motion instead show only one line. This also happens in empty line three. -> CR should not have two lines.-> is in the second part of my comment
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


resolves #5164
resolves #5165
resolves #5355
reoslves potentionally OpenSlides/OpenSlides#6927
Needs:
OpenSlides/openslides-autoupdate-service#1329
OpenSlides/openslides-backend#3126
Additional Info:
OpenSlides/openslides-meta#307