fix(security): revoke tokens and invalidate sessions on password change#117
Open
fix(security): revoke tokens and invalidate sessions on password change#117
Conversation
Collaborator
mulldug
commented
Mar 9, 2026
mulldug
commented
- Introduce RevokeUserGrants job (replaces RevokeUserGrantsOnExplicitLogout) with an optional client_id and a reason parameter; remove the guard clause that silently prevented all-client revocation.
- Wire RevokeUserGrants to UserPasswordResetSuccessful so all OAuth2 tokens are revoked whenever a password is reset or changed.
- Rotate remember_token in User::setPassword() to invalidate remember-me cookies on other devices.
- Regenerate the session in UserApiController::updateMe() after a password change to protect against session fixation.
- Add DELETE /admin/api/v1/users/me/tokens endpoint with a corresponding "Sign Out All Other Devices" button on the profile page.
- Add PasswordChangeRevokeTokenTest covering all eight scenarios from the security specification.
- Introduce RevokeUserGrants job (replaces RevokeUserGrantsOnExplicitLogout)
with an optional client_id and a reason parameter; remove the guard
clause that silently prevented all-client revocation.
- Wire RevokeUserGrants to UserPasswordResetSuccessful so all OAuth2
tokens are revoked whenever a password is reset or changed.
- Rotate remember_token in User::setPassword() to invalidate remember-me
cookies on other devices.
- Regenerate the session in UserApiController::updateMe() after a
password change to protect against session fixation.
- Add DELETE /admin/api/v1/users/me/tokens endpoint with a corresponding
"Sign Out All Other Devices" button on the profile page.
- Add PasswordChangeRevokeTokenTest covering all eight scenarios from
the security specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.