Conversation
4f4b976 to
9ed27c0
Compare
d46a3d6 to
ba24e02
Compare
c94fc68 to
9a8387b
Compare
ba24e02 to
91e997c
Compare
PrivateCloudsApiController
f907c52 to
d5ecc7a
Compare
d5ecc7a to
923fa2c
Compare
caseylocker
approved these changes
Nov 14, 2025
caseylocker
requested changes
Nov 14, 2025
caseylocker
left a comment
There was a problem hiding this comment.
Still needs work.
- Expand on the 'order' parameter description.
description: 'Order by field(s). Available fields: id, name. Use "-" prefix for descending order.',
- Missing pagination parameters (page, per_page). Add 'page' and 'per_page' parameters to the controller
Example:
new OA\Parameter(
name: 'page',
in: 'query',
required: false,
description: 'Page number for pagination',
schema: new OA\Schema(type: 'integer', example: 1)
),
new OA\Parameter(
name: 'per_page',
in: 'query',
required: false,
description: 'Items per page',
schema: new OA\Schema(type: 'integer', example: 10, maximum: 100)
),
- Enhance filter operator descriptions (=@ means "starts with", etc.)
...Operators: == (equals), =@ (starts with), @@ (contains).',
- Clarify expand parameter behavior (what gets replaced on expansion.)
Contributor
Author
|
All the requested changes were introduced. I don't understand what is missing. |
6ce1385 to
894ef11
Compare
894ef11 to
7ba5958
Compare
caseylocker
requested changes
Dec 11, 2025
caseylocker
left a comment
There was a problem hiding this comment.
Replace response: 200 with response: Response::HTTP_OK then it should be good to go.
7ba5958 to
7fc30ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkg8t
Depends on PR #362