Conversation
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
from
25fd73e to
444f6eb
Compare
smarcet
force-pushed
the
main
branch
9 times, most recently
from
c94fc68 to
9a8387b
Compare
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
from
444f6eb to
063ffca
Compare
matiasperrone-exo
changed the title
OAuth2ChunkedFilesApiController
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
3 times, most recently
from
04ae0f0 to
80b0d40
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
from
80b0d40 to
41f1fd9
Compare
caseylocker
requested changes
Oct 30, 2025
There was a problem hiding this comment.
There's a status property for uploads that seems to be missing in schemas.php.
After the 'done' property there should also be a 'status' property:
new OA\Property(property: 'status', type: 'boolean', example: true, description: 'Upload status indicator'),
Minor but when that's fixed it should be good to go.
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
from
e8a53db to
6684f9a
Compare
| /** @var AbstractHandler $handler */ | ||
| $handler = $save->handler(); | ||
| $done = $handler->getPercentageDone(); | ||
| return response()->json([ |
Contributor
Author
There was a problem hiding this comment.
@caseylocker As you can see there is only "done" as field
fix: improve ticket repository performance remove not needed extra joins fix: set fetchJoinCollection to false for ticket repo fix: get always owner to avoid N+1 on ticket repository fix: improve get tickets generic pagination
chore: fix .gitmessage.txt chore: increase header size to 150
- Add controller's response to OpenAPI schema
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2chunkedfilesapicontroller
branch
from
6684f9a to
e78c2c2
Compare
caseylocker
approved these changes
Nov 12, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
The swagger changes look ok. @smarcet Please review and if you approve please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkgjd