Skip to content

Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController#376

Merged
smarcet merged 8 commits intomainfrom
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller
Dec 3, 2025
Merged

Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController#376
smarcet merged 8 commits intomainfrom
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo commented Oct 2, 2025

Task:

Ref: https://app.clickup.com/t/86b6wkh3f

Aditional Notes

  • Fix: Typo seet_type should be seat_type in RSVPAdminAddRequest schema

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 2, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch from 1693f45 to 767935c Compare October 2, 2025 16:05
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller Apis/Protected/Summit/OAuth2SummitMediaFileTypeApiController.php Feature | Extend Swagger Coverage for controller Apis/Protected/Summit/OAuth2SummitBadgeFeatureTypeApiController.php Oct 2, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch 2 times, most recently from b65b22d to e128e9c Compare October 2, 2025 17:49
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 7, 2025
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller Apis/Protected/Summit/OAuth2SummitBadgeFeatureTypeApiController.php Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController.php Oct 8, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch from e128e9c to d3e4f3d Compare October 8, 2025 22:11
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController.php Feature | Extend Swagger Coverage for controller OAuth2SummitBadgeFeatureTypeApiController Oct 14, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch 2 times, most recently from e8f95c9 to 610452a Compare October 14, 2025 17:24
caseylocker
caseylocker requested changes Oct 31, 2025
View reviewed changes
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same issue with 'oauth2_security_scope' as mentioned in others. It's a security scope that is not defined, and needs to be, in app/Swagger/schemas.php.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch from 2d4af5e to 12b8784 Compare October 31, 2025 18:37
@matiasperrone-exo
Copy link
Contributor Author

matiasperrone-exo commented Oct 31, 2025 •
edited
Loading

This has the same issue with 'oauth2_security_scope' as mentioned in others. It's a security scope that is not defined, and needs to be, in app/Swagger/schemas.php.

@caseylocker thanks, all the changes are now implemented

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitbadgefeaturetypeapicontroller branch from 9ba612a to e77db3b Compare November 7, 2025 21:56
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
caseylocker
caseylocker requested changes Nov 19, 2025
View reviewed changes
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone Very close.

None of the endpoints have operationId defined. Add:
GET all: operationId: 'getAllBadgeFeatureTypes'
GET one: operationId: 'getBadgeFeatureType'
POST: operationId: 'createBadgeFeatureType'
PUT: operationId: 'updateBadgeFeatureType'
DELETE: operationId: 'deleteBadgeFeatureType'
POST image: operationId: 'addBadgeFeatureTypeImage'
DELETE image: operationId: 'deleteBadgeFeatureTypeImage'

That should do it.

caseylocker
caseylocker approved these changes Nov 28, 2025
View reviewed changes
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo Looks good. @smarcet if you agree please merge.

smarcet
smarcet approved these changes Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 77132c5 into main Dec 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caseylocker caseylocker caseylocker approved these changes

@smarcet smarcet smarcet approved these changes

Assignees

@matiasperrone-exo matiasperrone-exo

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matiasperrone-exo @caseylocker @smarcet @matiasperrone