feat: add new load graph by relation trait#384
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new functionality to load entity graphs with relations efficiently to address N+1 query problems when fetching summit data. The main goal is to improve performance by implementing a graph loading trait that can eagerly load related entities in optimized queries.
Key changes:
- Added a new
GraphLoaderTraitfor efficient entity graph loading with relation support - Enhanced the Summit repository with new methods that utilize the graph loading functionality
- Updated the Summit finder strategy to support relation preloading
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
app/libs/Utils/Doctrine/GraphLoaderTrait.php |
New trait implementing graph loading logic for entities with relations |
app/Repositories/Summit/DoctrineSummitRepository.php |
Added graph loading trait usage and new methods for loading summits with relations |
app/Models/Foundation/Summit/Repositories/ISummitRepository.php |
Added interface methods for relation-based summit retrieval |
app/Http/Controllers/Apis/Protected/Summit/Strategies/ISummitFinderStrategy.php |
Updated interface to support relations parameter |
app/Http/Controllers/Apis/Protected/Summit/Strategies/CurrentSummitFinderStrategy.php |
Implemented relation support in summit finder strategy |
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitApiController.php |
Updated summit retrieval to use relation preloading |
tests/OAuth2SummitApiTest.php |
Added test case for summit retrieval with relations parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public function find($summit_id) | ||
| public function find($summit_id, array $relations = []) | ||
| { | ||
| if(count($relations) > 0){ |
There was a problem hiding this comment.
Missing space after 'if' keyword. Should be 'if (count($relations) > 0) {' to follow PHP coding standards.
Suggested change
| if(count($relations) > 0){ | |
| if (count($relations) > 0){ |
| { | ||
| if(count($relations) > 0){ | ||
| $summit = $summit_id === 'current' ? $this->repository->getCurrentAndRelations($relations) : $this->repository->getByIdAndRelations(intval($summit_id), $relations); | ||
| if(is_null($summit)) |
There was a problem hiding this comment.
Missing space after 'if' keyword. Should be 'if (is_null($summit))' to follow PHP coding standards.
Suggested change
| if(is_null($summit)) | |
| if (is_null($summit)) |
chore: improvee performance of get summit by id ( N + 1 ) problem
smarcet
force-pushed
the
feature/load-graph-by-relations-at-repo
branch
from
f6ae70b to
347251f
Compare
smarcet
added a commit
that referenced
this pull request
Oct 7, 2025
chore: improvee performance of get summit by id ( N + 1 ) problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6z5t03
feat: add new load graph by relation trait
chore: improve performance of get summit by id ( N + 1 ) problem