Conversation
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitpresentationactiontypeapicontroller
branch
from
68f63a5 to
31cb699
Compare
matiasperrone-exo
added
the
documentation
caseylocker
requested changes
Nov 5, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
I'm guessing "require DIR . DIRECTORY_SEPARATOR . "SummitPresentationSchemas.php";" was removed from schemas.php accidentally? Looks like a breaking change. Please verify and retest before submitting again.
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitpresentationactiontypeapicontroller
branch
from
dd9bdff to
2c513e0
Compare
Contributor
Author
|
@caseylocker please review this one. Check the changes again, thanks |
caseylocker
requested changes
Nov 28, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo wrong namespace in app/Swagger/Security/PresentationActionTypesAuthSchema.php
// Current (WRONG)
namespace App\Swagger\Security;
// Required (CORRECT)
namespace App\Swagger\schemas;
Also missing operationId on the 6 endpoints. See below for suggestions:
| GET /api/v1/summits/{id}/presentation-action-types | getAllPresentationActionTypes |
|---|---|
| GET /api/v1/summits/{id}/presentation-action-types/csv | exportPresentationActionTypesCsv |
| GET /api/v1/summits/{id}/presentation-action-types/{action_id} | getPresentationActionType |
| POST /api/v1/summits/{id}/presentation-action-types | createPresentationActionType |
| PUT /api/v1/summits/{id}/presentation-action-types/{action_id} | updatePresentationActionType |
| DELETE /api/v1/summits/{id}/presentation-action-types/{action_id} | deletePresentationActionType |
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitpresentationactiontypeapicontroller
branch
from
9eabb3d to
13f06c1
Compare
Collaborator
|
@matiasperrone please rebase against main and fix the conflicts many thanks |
smarcet
force-pushed
the
main
branch
4 times, most recently
from
c6ecdd0 to
728ae67
Compare
…nActionTypeApiController`
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitpresentationactiontypeapicontroller
branch
from
13f06c1 to
3c0ac79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh3q