Conversation
4f42a74 to
9c71954
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Doc generation is failing.
Verify parameter references exist for:
new OA\Parameter(ref: '#/components/parameters/page'),
new OA\Parameter(ref: '#/components/parameters/per_page'),
Or create them.
Also verify security schema exists for 'OAuth2'
4e15e16 to
2a194d4
Compare
|
@caseylocker The security schema for the controller was moved to its own file and the doc generation is working now |
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo Namespace issue in the controller.
// Current (WRONG)
namespace App\Swagger\Security;
// Required (CORRECT)
namespace App\Swagger\schemas;
Also missing operationIds. Suggestions below:
| GET /api/v1/summits/{id}/sponsorships-types | getAllSponsorshipTypes |
|---|---|
| POST /api/v1/summits/{id}/sponsorships-types | createSponsorshipType |
| GET /api/v1/summits/{id}/sponsorships-types/{type_id} | getSponsorshipType |
| PUT /api/v1/summits/{id}/sponsorships-types/{type_id} | updateSponsorshipType |
| DELETE /api/v1/summits/{id}/sponsorships-types/{type_id} | deleteSponsorshipType |
| POST .../badge-image | addSponsorshipTypeBadgeImage |
| DELETE .../badge-image | deleteSponsorshipTypeBadgeImage |
48a1884 to
5f34317
Compare
|
@matiasperrone please rebase against main and fix the conflicts many thanks |
c6ecdd0 to
728ae67
Compare
5f34317 to
d111df8
Compare
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSponsorshipTypeApiController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSponsorshipTypeApiController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSponsorshipTypeApiController.php
Outdated
Show resolved
Hide resolved
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please review
…TypeApiController`
…nActionTypeApiController`
Signed-off-by: Matias Perrone <github@matiasperrone.com>
d111df8 to
fdff706
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
fdff706 to
3b7f0ad
Compare
|
Thanks @smarcet for the comments. Now is ready to review again as it was rebased and the incorrect methods were removed. |
Task:
Ref: https://app.clickup.com/t/86b6wkh3t