Conversation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitattendeebadgeprintapicontroller
branch
2 times, most recently
from
3d5cf3a to
ba8802d
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitattendeebadgeprintapicontroller
branch
from
22c1bce to
0ed0ceb
Compare
matiasperrone-exo
added
review
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitattendeebadgeprintapicontroller
branch
from
5459d18 to
16fb763
Compare
Contributor
Author
|
Added security schema to controller file |
Contributor
Author
|
@caseylocker The security schema for the controller was created in its own file |
caseylocker
requested changes
Nov 29, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo missing operationIds in OAuth2SummitAttendeeBadgePrintApiController
| Endpoint | Suggested operationId |
|---|---|
| GET .../badge/current/prints | getBadgePrintsForTicket |
| GET .../badge/current/prints/csv | exportBadgePrintsCsv |
| DELETE .../badge/current/prints | deleteBadgePrintsForTicket |
There's an issue with a parameter:
The path uses {id} for summit but parameter is named summit_id:
// Path says {id}
path: "/api/v1/summits/{id}/tickets/{ticket_id}/badge/current/prints"
// But parameter says summit_id
new OA\Parameter(
name: 'summit_id', // Should be 'id' to match path
...
)
Looks like there's an unused import:
use App\Swagger\Security\BadgePrintsAuthSchema;
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitattendeebadgeprintapicontroller
branch
from
1861ce5 to
d27e261
Compare
…gePrintApiController`
…ontrollerSecurityScheme
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitattendeebadgeprintapicontroller
branch
from
d27e261 to
aafbea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh57