Conversation
4b586da to
e476b84
Compare
e476b84 to
af9823b
Compare
bc3a5d2 to
dfa0eeb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenAPI documentation for the SummitAdministratorPermissionGroup API endpoints, including schemas for CRUD operations and relationship management (adding/removing members and summits).
Key changes:
- Added comprehensive OpenAPI schemas for SummitAdministratorPermissionGroup entities and operations
- Added OAuth2 security scheme definition for summit administrator groups
- Documented all API endpoints including GET, POST, PUT, and DELETE operations with request/response definitions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| app/Swagger/SummitAdministratorPermissionGroupSchemas.php | Defines OpenAPI schemas for SummitAdministratorPermissionGroup, including the main entity schema, create/update request schemas, and paginated list response schema |
| app/Swagger/Security/SummitAdminGroupsOauth2.php | Defines OAuth2 security scheme for summit administrator group endpoints with read and write scopes |
| app/Http/Controllers/Apis/Protected/Main/OAuth2SummitAdministratorPermissionGroupApiController.php | Adds OpenAPI annotations to all controller methods documenting endpoints, parameters, request bodies, responses, and security requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smarcet
reviewed
Nov 13, 2025
...tp/Controllers/Apis/Protected/Main/OAuth2SummitAdministratorPermissionGroupApiController.php
Outdated
Show resolved
Hide resolved
smarcet
reviewed
Nov 13, 2025
...tp/Controllers/Apis/Protected/Main/OAuth2SummitAdministratorPermissionGroupApiController.php
Outdated
Show resolved
Hide resolved
smarcet
requested changes
Nov 13, 2025
Collaborator
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please do rebase with main ( i found an issue on http verbs at main ) and review the comments
dfa0eeb to
0029ae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkh5t