Conversation
caseylocker
requested changes
Nov 29, 2025
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo Quick fix...
Per project conventions, the key should be 'required-groups'.
x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],
9a0aff2 to
807dea7
Compare
Contributor
Author
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
requested changes
Dec 3, 2025
caseylocker
left a comment
There was a problem hiding this comment.
Inconsistent x: Parameter Key
'required-groups' is correct and is used once here.
'authz_groups' is incorrect and is used 4 times here.
Change all:
x: [
'authz_groups' => [
//...
]
],
To
x: [
'required-groups' => [
//...
]
],
807dea7 to
ba84f9c
Compare
Contributor
Author
|
@caseylocker done! please review |
26b1624 to
2385dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh7x