Conversation
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo name space issue...
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT
Wrong x: Parameter Key Name
Write endpoints use 'authz_groups' instead of the standard 'required-groups':
x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],
This affects 7 endpoints (all write operations).
164c7d7 to
3422da7
Compare
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
LGTM. @smarcet please merge if you agree.
3422da7 to
b2c9ece
Compare
|
@matiasperrone please review conflicts |
b2c9ece to
8968905
Compare
|
@smarcet the conflicts are now resolved |
Task:
Ref: https://app.clickup.com/t/86b6wkh83