Conversation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
6de50a3 to
da99093
Compare
caseylocker
requested changes
Nov 29, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
Wrong x: Parameter Key Name
All endpoints use 'authz_groups' instead of the standard 'required-groups':
x: [
"authz_groups" => [...] // Wrong key name
],
Should be:
x: [
"required-groups" => [...] // Correct key name
],
Is this missing documentation for a POST endpoint?
POST /api/v1/summits/{id}/speakers-assistances/{assistance_id}/mail
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
da99093 to
8cbd0f8
Compare
Contributor
Author
|
Thanks @caseylocker for the comments. Now is ready to review again |
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
ca92c35 to
333b318
Compare
Collaborator
|
@matiasperrone please review conflicts |
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
333b318 to
d00f84d
Compare
smarcet
force-pushed
the
main
branch
4 times, most recently
from
c6ecdd0 to
728ae67
Compare
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
d00f84d to
58f5fdd
Compare
…istanceApiController`
…schema, fix path routes and change schema to be defined as requested
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
3 times, most recently
from
c1c4535 to
f18506f
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summitspeakersassistanceapicontroller
branch
from
f18506f to
c1d9309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh8b