feat: add first_name and last_name into OtlpStrategy#438
Merged
Conversation
smarcet
reviewed
Oct 23, 2025
| $user_id = $resource_server_ctx->getCurrentUserId(); | ||
| $user_email = $resource_server_ctx->getCurrentUserEmail(); | ||
|
|
||
| $user = $resource_server_ctx->getCurrentUser(false, false); |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 please do a main rebase and use these new methods from resource context
instead of getting current user
9bb2c6c
smarcet
requested changes
Oct 23, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments many thanks
andrestejerina97
force-pushed
the
feature/add-field-in-auditotlpstrategy
branch
from
003e3c5 to
5ec3dbd
Compare
andrestejerina97
force-pushed
the
feature/add-field-in-auditotlpstrategy
branch
from
5ec3dbd to
4ae663f
Compare
smarcet
reviewed
Oct 24, 2025
app/Audit/AuditLogOtlpStrategy.php
Outdated
| @@ -62,6 +62,8 @@ public function audit($subject, array $change_set, string $event_type): void | |||
| $resource_server_ctx = App::make(\models\oauth2\IResourceServerContext::class); | |||
| $user_id = $resource_server_ctx->getCurrentUserId(); | |||
Collaborator
There was a problem hiding this comment.
@andrestejerina97 sorry for the back and forth but as u may know from latest slack conversation we are sending the wrong data at $user_id
so we will need to use your original approach
$user = $resource_server_ctx->getCurrentUser(false, false);
and get do $user_id = $user->getId();
smarcet
requested changes
Oct 24, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6r27rt?comment=90140149532551