feat: : Add a formatter for entities related to speaker presentations.#466
Closed
andrestejerina97 wants to merge 4 commits intomainfrom
Closed
feat: : Add a formatter for entities related to speaker presentations.#466andrestejerina97 wants to merge 4 commits intomainfrom
andrestejerina97 wants to merge 4 commits intomainfrom
Conversation
matiasperrone-exo
changed the title
andrestejerina97
changed the title
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
3 times, most recently
from
7a0f72c to
196c76c
Compare
caseylocker
reviewed
Dec 4, 2025
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
DRY suggestion: Refactor to deduplicate the getUserInfo() function that's copied in multiple formatter classes. Suggest moving it to AbstractAuditLogFormatter
smarcet
reviewed
Dec 4, 2025
| $this->event_type = $event_type; | ||
| } | ||
|
|
||
| private function getUserInfo(): string |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 move this to AbstractAuditLogFormatter and remove dupe code
smarcet
requested changes
Dec 4, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@andrestejerina97 please review comments
smarcet
reviewed
Dec 4, 2025
|
|
||
| switch ($this->event_type) { | ||
| case IAuditStrategy::EVENT_ENTITY_CREATION: | ||
| $submission_dates = $subject->getSubmissionBeginDate() && $subject->getSubmissionEndDate() |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 use SelectionPlan::hasSelectionPeriodDefined helper method here
smarcet
reviewed
Dec 4, 2025
| $plan_name = $selection_plan ? $selection_plan->getName() : 'Unknown Plan'; | ||
|
|
||
| switch ($this->event_type) { | ||
| case IAuditStrategy::EVENT_ENTITY_CREATION: |
Collaborator
There was a problem hiding this comment.
@andrestejerina97 this logic is not quite rite , a presentation could be created from show admin itself
in order to apply this strategy u need to check that endpoint being called is
POST api/v1/summits/{id}/presentations
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
d4d163c to
6b32c8b
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
6b32c8b to
8d57aeb
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
8d57aeb to
0065fe8
Compare
andrestejerina97
force-pushed
the
feature/add-formatter-call-for-speaker
branch
from
0065fe8 to
9b97589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7n0xv4