Merged
Conversation
selvanair
reviewed
Apr 2, 2026
| #define IDS_LANGUAGE_NAME 1650 | ||
|
|
||
| /* Win32 Service Related */ | ||
| /* historic: #define IDS_ERR_OPEN_SCMGR_ADMIN 1701 */ |
Collaborator
There was a problem hiding this comment.
Last time when we removed some such defines, the consensus was to keep them commented out to avoid reuse (see #80 ). I do not personally feel that is necessary (i.e., reuse is fine), but just clarifying the origin of such comments, in case anyone cares to preserve them.
Member
Author
There was a problem hiding this comment.
I don't think these numbers are ever transmitted somewhere, are they? They are only used by the compiler? So I think it should be perfectly safe to reuse them.
flichtenheld
force-pushed
the
res-cleanup
branch
3 times, most recently
from
5a04334 to
b428ceb
Compare
There are many, many strings that are not used since a decade or more. Do a general cleanup. Adds the script used to do the cleanup as res/cleanup_res_ids.sh Note that the script does not do actually remove anything (unless you enable some code that is commented out). All ids were checked manually before removal. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
flichtenheld
force-pushed
the
res-cleanup
branch
from
ea4da1d to
3050908
Compare
Didn't cause any issues so far, but make sure we do not match the wrong ID if one name is the prefix of another. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
selvanair
approved these changes
Apr 14, 2026
Collaborator
selvanair
left a comment
selvanair
left a comment
There was a problem hiding this comment.
Wow, this is some cleanup! Looks good.
A future enhancement could be to extend the script to also look for missing entries in non-English resource files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many, many strings that are not used since a decade or more. Do a general cleanup.
Note: cleanup is incomplete. So created as a draft PR.