[CVE] remove nokogiri and dependencies#61
Closed
binford2k wants to merge 2 commits intoOpenVoxProject:mainfrom
Closed
[CVE] remove nokogiri and dependencies#61binford2k wants to merge 2 commits intoOpenVoxProject:mainfrom
binford2k wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
Nokogiri was used to bump performance on MacOS clients when parsing plist files. Without it, CFPropertyList will fall back to rexml. However, performance testing indicates that the boost is negligible. This just removes it and reduces our security exposure. This removes the libxml2 & libxslt libraries from the agent runtime, but doesn't actually delete the components yet because Bolt uses them.
bastelfreak
approved these changes
Sep 12, 2025
Member
|
I'm going to roll this into my cross-compilation PR (assuming I can get that over the finish line). |
Member
|
Closing in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nokogiri was used to bump performance on MacOS clients when parsing
plist files. Without it, CFPropertyList will fall back to rexml.
However, performance testing indicates that the boost is negligible.
This just removes it and reduces our security exposure.
This removes the libxml2 & libxslt libraries from the agent runtime, but
doesn't actually delete the components yet because Bolt uses them.