fix(ui-builder): hide explorer health banner when contract load succeeds without it#374
Draft
fix(ui-builder): hide explorer health banner when contract load succeeds without it#374
Conversation
…eds without it Filter proactive explorer NetworkServiceErrorBanner on the contract step when Sourcify supplies the ABI, manual ABI is used, or a load is in progress. RPC and other unhealthy services are unchanged. Co-authored-by: Aleksandr Pasevin <aleksandr.pasevin@openzeppelin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the proactive Block Explorer Unavailable
NetworkServiceErrorBanneron the Load Contract step when it would be misleading: after a successful Sourcify fetch (metadatafetchedFromcontainssourcify), when the user loaded via manual ABI, or while a contract load is in progress (avoids flashing the banner before fallback runs). Other unhealthy services (e.g. RPC) are unchanged.Implementation
filterUnhealthyServicesForContractDefinitionStep+ unit tests.StepContractDefinitioncomposes health check output with contract store state before rendering banners.Testing
pnpm --filter=@openzeppelin/ui-builder-app test(Vitest, including new filter tests).