Better press page#196
Better press page#196kylemh merged 36 commits intoOperationCode:masterfrom dirtyredz:BetterPressPage
Conversation
|
This pull request is automatically deployed with Now. |
|
Looks like a few updates have been made since ive opened this branch. |
|
🤖 This is a bot 🤖 Built with commit cc2c97d https://deploy-preview-196--operation-code-storybook.netlify.com |
|
Styles were pulled from OperationCode/operationcode_frontend#1024 |
|
The conflicts are going to be pretty rough to resolve 😥 I recommend closing this PR and copy-pasting to the correct spots, as I moved some folders around (I simply wanted to modularize content). Thanks so much for working to simplify this! I love the direction your going. When you're done porting over, you can ignore test coverage for the data structure containing all the links via changing |
|
Will Do |
|
@kylemh Merged/Updated and moved the new PressLinks into the Press directory. should be ready for a merge. |
kylemh
left a comment
kylemh
left a comment
There was a problem hiding this comment.
Amazing work. Solid test coverage and it looks super clean.
Mostly variable naming changes and some edits in the testing. I gave you the tools needed to accomplish your UI for the "show all" button.
|
All make these fixes asap, and thanks for taking the time to explain yourself on the changes. It helps me better understand what your wanting, making it easier for me to help you guys out. |
|
No problem at all @dirtyredz - hopefully it's useful info. Feel free to @ me on Slack at any moment. Let's get you a shirt in addition to those stickers 😉 |
|
just need to work on the button aria portion |
|
There we go, that should resolve everything. Again thanks for the collaboration very helpful!! |
|
I made some commits to make small edits to things I didn't wanna bother you about - be sure to pull and update snapshot tests - the build should resolve again |
|
ugh, I ALWAYS forget to update component names... lol, thanks for those fixes. Ill pull and resolve the remaining reviews. |
dirtyredz
left a comment
dirtyredz
left a comment
There was a problem hiding this comment.
... I was totally being lazy one this one, cant get nothing past you.
|
Thank you, and great job yourself keeping me on my toes. |
|
Tonight ill do a PR for updated Linting rules specifically alpha order and imports. |
|
@dirtyredz less about keeping you on your toes and more about me being nitpicky. Thanks ahead of time for doing that issue! |
|
@dirtyredz will you do me the favor of pulling changes and pushing snapshot updates? |
|
sure |
2 participants
Description of changes
Adds "In The News" section to the Press page.
Fixes minor styling issues.
Updates testing for common button component for handling onClick.
Issue Resolved
Fixes #171
As it now adds the missing article links.
Screenshots/GIFs