Skip to content

Supernova AMO additions#2811

Merged
sparrowDom merged 5 commits intosparrowDom/supernovaAMOfrom
nicka/supernovaAMO
Feb 26, 2026
Merged

Supernova AMO additions#2811
sparrowDom merged 5 commits intosparrowDom/supernovaAMOfrom
nicka/supernovaAMO

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Feb 24, 2026

Changes

  • Removed asset and oToken from StableSwapAMMStrategy constructor
  • Added oToken to IVault which is used by StableSwapAMMStrategy constructor
  • Removed calculateRedeemOutput and calculateRedeemOutputs from IVault
  • Fixes to the Sonic fork tests

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Added oToken to IVault which is used by StableSwapAMMStrategy constructor
Removed calculateRedeemOutput and calculateRedeemOutputs from IVault
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.39%. Comparing base (15bc2af) to head (03b22b0).
⚠️ Report is 1 commits behind head on sparrowDom/supernovaAMO.

Files with missing lines Patch % Lines
...ntracts/strategies/sonic/SonicSwapXAMOStrategy.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           sparrowDom/supernovaAMO    #2811      +/-   ##
===========================================================
+ Coverage                    41.24%   44.39%   +3.14%     
===========================================================
  Files                          106      106              
  Lines                         4485     4487       +2     
  Branches                      1225     1225              
===========================================================
+ Hits                          1850     1992     +142     
+ Misses                        2632     2492     -140     
  Partials                         3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 mentioned this pull request Feb 24, 2026
@naddison36 naddison36 marked this pull request as ready for review February 24, 2026 08:09
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these simplifications and fixes. Merging in

@sparrowDom sparrowDom merged commit eb15b5b into sparrowDom/supernovaAMO Feb 26, 2026
14 of 17 checks passed
@sparrowDom sparrowDom deleted the nicka/supernovaAMO branch February 26, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants