Skip to content

Minor contract fixes#2815

Open
naddison36 wants to merge 4 commits intomasterfrom
nicka/plume-vault
Open

Minor contract fixes#2815
naddison36 wants to merge 4 commits intomasterfrom
nicka/plume-vault

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Feb 26, 2026

Changes

  • Fix OETHPlumeVault override of the internal _mint
  • Fixed error message in Curve AMO setMaxSlippage
  • Removed extra FactoryRemoved events from removeFactory on PoolBoostCentralRegistry
  • Fixed param order in DripRateUpdated event

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.36%. Comparing base (6f80e57) to head (fec9d4c).

Files with missing lines Patch % Lines
contracts/contracts/harvest/FixedRateDripper.sol 0.00% 1 Missing ⚠️
...acts/contracts/strategies/BaseCurveAMOStrategy.sol 0.00% 1 Missing ⚠️
...ontracts/contracts/strategies/CurveAMOStrategy.sol 0.00% 1 Missing ⚠️
contracts/contracts/vault/OETHPlumeVault.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2815      +/-   ##
==========================================
- Coverage   45.06%   44.36%   -0.71%     
==========================================
  Files         105      105              
  Lines        4500     4499       -1     
  Branches     1228     1228              
==========================================
- Hits         2028     1996      -32     
- Misses       2469     2500      +31     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 changed the title Fix OETHPlumeVault override of the internal _mint Minor contract fixes Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant