Conversation
not really needed and has been reported as problematic[1] [1] https://issues.oss-fuzz.com/issues/478301105
|
The issue that it "solves" was actually unrelated to the reported fix. I was unable to find the corresponding issue that it claimed to solve, actually, so I expect it was hallucinated or corresponds to a testcase we otherwise don't see. |
|
@oliverchang Can you provide additional context as to how #881 came about? I have made an assumption above, but I would hope that there is a corresponding issue you can point to. |
|
The code you're removing here looks OK to me? If there is a crash, then we would ideally fix it rather than remove the test code. |
|
For what it's worth, I wasn't able to reproduce this one. (There was another OSS-Fuzz crash that's rather hard to exercise, on 32-bit CPUs only, and I have a fix I need to submit for that.) |
addisoncrump
left a comment
addisoncrump
left a comment
There was a problem hiding this comment.
Looking over this, AFAICT this might increase the frequency of timeouts (though, presumably, the internal timeout mechanisms in PCRE2 have improved since this code was written) and we will not exercise callout functionality, which could be a testing blind spot but a fairly low-importance one. OSS-Fuzz will let us know if there are more issues, and this doesn't touch any user-facing code so there's no harm in experimenting a bit.
3 participants
This could be used as an "alternative solution" for the issue referred in #881
Posted as a draft, as it hasn't been even tested and I have no access to that issue to confirm it actually "solves" it