Conversation
dilpath
commented
May 29, 2024
- functionality
- read/write
- OOP
- methods for tools
- to_events
- to_sequence_of_petab
- to_single_petab_and_sequence_of_metadata
- optimize_metadata_to_reduce_redundant_simulations
- optimize_metadata_to_reduce_events_or_unique_petabs_in_sequence_of_petabs
- linter validation checks
- test all functionality
- docs
…ses to problem tests
…e`; add dependency
Add basic support for PEtab version 2 experiments (see also PEtab-dev/PEtab#586, and PEtab-dev/PEtab#581). Follow-up to #334. Partially supersedes #263, which was started before petab.v1/petab.v2 were introduced and before PEtab-dev/PEtab#586. * updates the required fields in the measurement table * updates some validation functions to not expect the old `simulationConditionId`s (but does not do full validation yet) * extends PEtab v1 up-conversion to create a new experiment table. --------- Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
|
Does it make sense to work on this now? Are there analogous functions for v1, or is all of this specific to the experiments table?
|
The "methods for tools" is still relevant, but I think there's nothing important to keep from this PR, and it's easier to implement from scratch based on the current support for experiments implemented in #332.
This kind of output triplet data is what I meant by "metadata". The output of
This is what I'm currently using, because it simplifies writing a wrapper around AMICI. Since each PEtab problem has a dummy measurement at the final timepoint of each period, AMICI knows to stop simulating when the current period ends. I then update the system according to the next period and ask AMICI to simulate the next PEtab problem with the custom initial condition.
This metadata could be a sequence of tuples like I guess there are many ways to implement this, alternative suggestions are welcome. |