v2: Adapt to updated yaml schema#394
Merged
dweindl merged 1 commit intoPEtab-dev:mainfrom Jul 18, 2025
Merged
Conversation
dweindl
force-pushed
the
multimodel
branch
2 times, most recently
from
4b97231 to
13cab07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 73.96% 74.01% +0.05%
==========================================
Files 60 60
Lines 6636 6642 +6
Branches 1152 1154 +2
==========================================
+ Hits 4908 4916 +8
+ Misses 1289 1288 -1
+ Partials 439 438 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
multimodel
branch
2 times, most recently
from
19537c9 to
8b85581
Compare
dilpath
approved these changes
Jul 18, 2025
petab/v2/problem.py
Outdated
Comment on lines
1181
to
1183
| # TODO: rename to parameter_files in yaml for consistency with other files? | ||
| # always a list? |
Basically, the `problems` list is disolved and its contents moved one level up. See https://github.com/PEtab-dev/PEtab/pull/622/files Related to PEtab-dev#392.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, the
problemslist is dissolved and its contents moved one level up.See https://github.com/PEtab-dev/PEtab/pull/622/files
Closes #391.
Related to #392.