v2: Paths as pathlib.Path & validate assignment#410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 73.86% 73.88% +0.02%
==========================================
Files 62 62
Lines 6764 6771 +7
Branches 1194 1196 +2
==========================================
+ Hits 4996 5003 +7
Misses 1308 1308
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For petab.v2 pydantic models, change path attributes to `pathlib.Path`, and validate assignments.
d5fa2ec to
b6f7136
Compare
dilpath
left a comment
There was a problem hiding this comment.
For multiple e.g. measurement tables, are the (relative) paths stored with the table names? If so, is there a method for users to add a table via a path, to a pre-existing list of measurement tables? If not, how should multiple tables be written to disk? Manually specify each individual table filename each write?
Not yet.
To be decided. |
|
We should probably drop |
|
Yes, moving the information to the table objects sounds nice to me 👍 Default filenames so that we can still have some kind of |
For petab.v2 pydantic models, change path attributes to
pathlib.Path, and validate assignments.