v2: Store path info in *Table objects#416
Merged
dweindl merged 4 commits intoPEtab-dev:mainfrom Aug 19, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 74.43% 74.59% +0.16%
==========================================
Files 61 62 +1
Lines 6700 6735 +35
Branches 1183 1188 +5
==========================================
+ Hits 4987 5024 +37
+ Misses 1257 1256 -1
+ Partials 456 455 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
table_paths
branch
2 times, most recently
from
45cb0a3 to
ccc5965
Compare
dweindl
force-pushed
the
table_paths
branch
4 times, most recently
from
2ae5174 to
7cc6e89
Compare
Store path info in *Table and Model objects to make it easier to read, modify, write complete PEtab problem. Add `Problem.to_files()`. Closes PEtab-dev#412.
m-philipps
approved these changes
Jul 31, 2025
Collaborator
m-philipps
left a comment
m-philipps
left a comment
There was a problem hiding this comment.
Looks sound, thank you
| "or a PEtab problem object." | ||
| ) | ||
|
|
||
| def to_files(self, base_path: str | Path | None) -> None: |
Collaborator
There was a problem hiding this comment.
base_path allows saving this to a different location from the base_path of the model/tables, right? If so, could you add this to the docstring?
Co-authored-by: Maren Philipps <55318391+m-philipps@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store path info in
*TableandModelobjects to make it easier to read, modify, write complete PEtab problem.Add
Problem.to_files().Closes #412.