v2: Basic support for multiple models#418
Merged
dweindl merged 1 commit intoPEtab-dev:mainfrom Jul 29, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 74.40% 74.39% -0.01%
==========================================
Files 61 61
Lines 6692 6691 -1
Branches 1182 1181 -1
==========================================
- Hits 4979 4978 -1
- Misses 1256 1257 +1
+ Partials 457 456 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-philipps
approved these changes
Jul 28, 2025
Collaborator
m-philipps
left a comment
There was a problem hiding this comment.
Thank you, nothing important to add from my side.
| ) | ||
|
|
||
| @model.setter | ||
| def model(self, value: Model): |
Collaborator
There was a problem hiding this comment.
Perhaps change the name to make it clear that this modifies the Problem, e.g. set_model?
Member
Author
There was a problem hiding this comment.
model is a property. This function here is usually invoked via problem.model = some_model, it cannot be invoked as problem.model(some_model). I think the assignment should make it clear that this modifies the object.
Related to PEtab-dev#392. * Let v2.Problem have a list of models * Support constructing v2.Problem from files with multiple models * Move some validators to Annotated * Add some TODOs.
96e40eb to
250d87c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #392.