Update v2 condition table targetValue validation#427
Merged
dweindl merged 1 commit intoPEtab-dev:mainfrom Sep 19, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 74.81% 74.82% +0.01%
==========================================
Files 62 62
Lines 6765 6792 +27
Branches 1195 1203 +8
==========================================
+ Hits 5061 5082 +21
- Misses 1252 1255 +3
- Partials 452 455 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dilpath
approved these changes
Aug 29, 2025
tests/v2/test_lint.py
Outdated
| applied at the start of an experiment.""" | ||
| problem = Problem() | ||
| problem.model = SbmlModel.from_antimony("p1 = 1; p2 = 2") | ||
| problem.add_experiment("e1", 0, "c1", 1, "c2") |
Member
There was a problem hiding this comment.
Unrelated: the docstring for add_experiment is currently missing that multiple conditions applied at a single timepoint are specified as a list inside args
libpetab-python/petab/v2/core.py
Lines 2100 to 2109 in 8795dbf
72afccb to
f8f18e0
Compare
After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'. Closes PEtab-dev#424.
f8f18e0 to
4df1ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'.
Closes #424.