Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 75.17% 75.17%
=======================================
Files 62 62
Lines 6847 6848 +1
Branches 1223 1223
=======================================
+ Hits 5147 5148 +1
Misses 1232 1232
Partials 468 468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Port `flatten_timepoint_specific_output_overrides`, `has_timepoint_specific_overrides`, `unflatten_simulation_df` and their respective tests to PEtab v2.
dweindl
force-pushed
the
v2_flatten_timepoint_specific_output_overrides
branch
from
744c530 to
a616088
Compare
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Looks good, thanks! Fine to merge as is.
petab/v2/core.py
Outdated
| from ..v1.core import get_notnull_columns | ||
| from ..v1.lint import is_scalar_float | ||
|
|
||
| measurement_df = self.measurement_df |
There was a problem hiding this comment.
Maybe these should be renamed to Problem.get_measurement_df to avoid confusing v1 PEtab users when they switch to v2. Otherwise they might try editing Problem.measurement_df directly like in v1 and wonder why their problem isn't changing. I think I might have been the one to suggest implementing Problem.measurement_df though...
There was a problem hiding this comment.
Tracked at #409. No strong opinion on this one. I think it could also be addressed through documentation.
dweindl
force-pushed
the
v2_flatten_timepoint_specific_output_overrides
branch
from
45b05f4 to
8fc20e3
Compare
dweindl
changed the title
flatten_timepoint_specific_output_overrides for PEtab v23 participants
Uh oh!
There was an error while loading. Please reload this page.